Repository navigation
ProxyAgent support proxy as URL #2278
Description
why not add proxy support as a URL?
import { env } from "./env.mjs";
import { ProxyAgent } from "undici";
// env.PROXY_URL = 'http://username:password@ip:port';
const proxy = new URL(env.PROXY_URL);
// WORK
export const proxyAgent = new ProxyAgent({
uri: proxy.origin + proxy.pathname,
token: `Basic ${Buffer.from(`${proxy.username}:${proxy.password}`).toString('base64')}`,
});
// DONT WORK
export const proxyAgent2 = new ProxyAgent(proxy);
Activity
Ethan-Arrowood commentedon Sep 21, 2023
I'm open to supporting both. But let's make sure it doesn't impact performance for the ProxyAgent instantiation.
metcoder95 commentedon Sep 21, 2023
PandaWorker commentedon Sep 21, 2023
99% of proxies use basic authorization. This won't affect anything. Through the parameters it will be possible to specify an explicit authorization type, if it is not basic
metcoder95 commentedon Sep 21, 2023
Hmm, never mind, I take back what I said; I read the deprecation wrongly. Basically is just about deprecating property
authin favour oftoken(sorry about that).Then, no issue at all; then SGTM adding support for object
URLsupportrossilor95 commentedon Mar 1, 2024
Since #2810 has been merged, can this be closed?
Uzlopak commentedon Mar 1, 2024
Yep