Skip to content

running autobahn test suite #3249

Closed

Description

@KhafraDev

We cannot move WebSocket out from experimental until we run the autobahn test suite.

https://github.com/crossbario/autobahn-testsuite

Activity

  1. added
    enhancementNew feature or request
    websocketPull requests or issues related to websocket and its standard
    on May 12, 2024
  2. Uzlopak commented on May 12, 2024

    @Uzlopak
    Contributor

    Maybe we can adapt it from this?

    https://github.com/search?q=repo%3Atheturtle32%2FWebSocket-Node%20autobahn&type=code

    I think we should do it in two steps.

    1. Add autobahn test suite and make it run via an npm script like npm run test:autobahn
    2. Fix errors thrown by autobahn incrementally
    3. If all tests pass, add it as part of the test:websocket npm script
  3. KhafraDev commented on May 12, 2024

    @KhafraDev
    MemberAuthor

    @Uzlopak thanks for the link, but I'd probably use ws' autobahn client script; a lot of what's implemented in Websocket-node is just a basic setup that the autobahn suite instructs us on how to setup already.

    autobahn tests don't exit out, it generates a report with passed/failed tests as an html file. We would instead publish the report on the docs site (for example).

    running the tests is relatively easy, but making a reproducible testing suite is the hard part. Also, the tests don't give information on what failed and we have to replicate each test in js which makes it hard.

  4. KhafraDev commented on May 12, 2024

    @KhafraDev
    MemberAuthor

    index.txt

    Here are the results. (rename to index.html, github wouldn't let me upload an html file...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestwebsocketPull requests or issues related to websocket and its standard

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions