Cache interceptor does not process capitalized Cache-Control header in request

Bug Description

Cache interceptor does not process Cache-Control: no-store request header if header name is capitalized.

In code we can see that you look for lowercased header name only.

You should convert header names to lowercase before search for cache-control;

Reproducible By

Please. see above.

Expected Behavior

Please. see above.

Logs & Screenshots

Environment

undici v7

Additional context

Can you add a reproduction? It's working correctly here.

import { Agent, fetch, interceptors } from "undici";

const dispatcher = new Agent().compose( interceptors.cache() );

for ( let n = 0; n < 2; n++ ) {
    const res = await fetch( "https://httpbingo.org/cache/60", {
        dispatcher,
        "headers": {
            "X-Data": new Date().toISOString(),
            "Cache-Control": "no-store",
        },
    } );

    console.log( ( await res.json() ).headers[ "X-Data" ] );
}

You can see, that data not changed - this means, that cached response used.
If you change Cache-Control header to the lower case - cache will be bypassed.

Ah right, thanks!

@mcollina

@mcollina this is related to that "normalizeHeaders" function I was working on that would always normalize the user passed headers. I think we should probably have a "pre-interceptor" that always does this to make things easier down chain.

Cannot be done on the DispatcherBase#dispatch directly?

fix: cache: treat cache-control request header case-insensitively

fix: cache: treat cache-control request header case-insensitively (no…

Navigation Menu

Repository navigation

Cache interceptor does not process capitalized `Cache-Control` header in request #3904

Bug Description

Reproducible By

Expected Behavior

Logs & Screenshots

Environment

Additional context

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Cache interceptor does not process capitalized Cache-Control header in request #3904

Description

Bug Description

Reproducible By

Expected Behavior

Logs & Screenshots

Environment

Additional context

Activity

mcollina commented on Nov 29, 2024

zdm commented on Nov 30, 2024

mcollina commented on Nov 30, 2024

ronag commented on Nov 30, 2024

metcoder95 commented on Dec 1, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Cache interceptor does not process capitalized `Cache-Control` header in request #3904