Skip to content

test: skip HTTP/2 churn test on Node.js 26 #5742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcollina merged 1 commit into from
Aug 31, 2026
Merged

test: skip HTTP/2 churn test on Node.js 26 #5742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions test/http2-request-never-settles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ const pem = require('@metcoder95/https-pem')
const { Agent } = require('..')

const nodeMajor = Number(process.versions.node.split('.')[0])
const skipOnAffectedNode = process.platform === 'linux' && (nodeMajor === 24 || nodeMajor === 25)
const skipForMemoryCorruption = process.platform === 'linux' && (nodeMajor === 24 || nodeMajor === 25)
const skipForOnreadAssertion = nodeMajor === 26

// completeRequestStream() runs on an h2 stream's 'close':
//
Expand Down Expand Up @@ -131,7 +132,8 @@ async function churningServer (rnd) {
for (const seed of SEEDS) {
test(`every h2 request settles under connection churn (seed ${seed})`, {
// https://github.com/nodejs/node/issues/64841
skip: skipOnAffectedNode && 'Node.js has an HTTP/2 memory corruption bug'
// https://github.com/nodejs/node/issues/64850
skip: (skipForMemoryCorruption || skipForOnreadAssertion) && 'Node.js has HTTP/2 session teardown crashes'
}, async (t) => {
const timer = setInterval(() => {}, 1000)
const rnd = makeRandom(seed)
Expand Down
Loading