Repository navigation
fix(fetch): don't enqueue the body twice when close is delayed - #6094
Open
cestercian wants to merge 1 commit into
Open
cestercian wants to merge 1 commit into
cestercian wants to merge 1 commit into
Conversation
A byte-sequence body is closed from a microtask. If pull runs again before that close, the same bytes were enqueued once more. Signed-off-by: Cestercian <yashafaid@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6092
For string and byte bodies,
pull()enqueues the whole thing and then closes the stream from aqueueMicrotask(because of nodejs/node#39758). Ifpull()runs again before that microtask, the same bytes got enqueued again, so the body could come out duplicated.This tracks whether the bytes were already enqueued and skips the enqueue (and the extra close) on later pulls. Async iterable bodies aren't touched.
Added
test/fetch/issue-6092.js, which delaysqueueMicrotaskwithsetImmediateand reads a string body and aUint8Arraybody. It gets 5 chunks before the change and 1 after.npm run lintpasses, and the fetch tests pass locally excepttest/fetch/cookies.js(HTTP/2 TLS handshake), which fails the same way on main for me.