Repository navigation
fix(websocket): lifecycle events queue integrated to handle sequential closing of websocket - #6099
Open
SudhansuBandha wants to merge 2 commits into
Open
SudhansuBandha wants to merge 2 commits into
SudhansuBandha wants to merge 2 commits into
Conversation
Signed-off-by: SudhansuBandha <bandhasudhansu@gmail.com>
Author
|
This is me contributing first time to Undici. I have done this setup that will adress the concering reported issues. Would love to have your feedback whether this is correct or not @KhafraDev based on your concerns. It would be great if you can suggest me further changes that will help me in addressing the bigger picture instead of simply fixing the reported issues |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented Queue to handle websocket lifecycle events.
Sequential Ordering of CLOSING and CLOSE websocket lifecycle events
Fixes: #4741
Fixes: #4742