Skip to content

fix(fetch): match multipart boundaries at line breaks - #6113

Open
tedy69 wants to merge 1 commit into
nodejs:mainfrom
tedy69:fix/multipart-boundary-matching
Open

tedy69 wants to merge 1 commit into
nodejs:mainfrom
tedy69:fix/multipart-boundary-matching

Conversation

@tedy69

@tedy69 tedy69 commented Oct 29, 2026

Copy link
Copy Markdown

Fixes #6112.

Match multipart boundaries with their CRLF prefix so boundary text inside a field or file is preserved. Adds Request and Response tests for text fields, binary files, following parts, and missing delimiters.

Validated with the fetch, unit, Web IDL, and busboy suites (2,233 tests passed), plus TypeScript and lint checks.

Signed-off-by: Tedy Fazrin <49227804+tedy69@users.noreply.github.com>

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter

codecov-commenter commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.61%. Comparing base (671acb3) to head (0974956).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6113   +/-   ##
=======================================
  Coverage   91.61%   91.61%           
=======================================
  Files         113      113           
  Lines       44070    44071    +1     
=======================================
+ Hits        40375    40376    +1     
  Misses       3695     3695           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

formData() rejects a valid multipart body when a part contains the boundary text mid-line

3 participants