Repository navigation
fix: keep the stack of fetch errors when __filename is undefined - #6116
Open
MIbtehajNasar wants to merge 1 commit into
Open
MIbtehajNasar wants to merge 1 commit into
MIbtehajNasar wants to merge 1 commit into
Conversation
When __filename is undefined (as in Node.js's bundled copy), the fetch wrapper called Error.captureStackTrace(err, module.exports.fetch) from the .catch callback. fetch is no longer on the stack there, so V8 recorded no frames and every error had an empty stack. Drop the constructorOpt, as nodejs#4812 intended. Fixes nodejs#6115
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes #6115
Rationale
When
__filenameis undefined, which is the case for the copy bundled into Node.js, thefetchwrapper callsError.captureStackTrace(err, module.exports.fetch)from the.catchcallback.fetchis no longer on the stack at that point, so V8 records no frames and every rejected error has an empty stack (justTypeError: fetch failed). #4812 meant this branch to fall back toError.captureStackTrace(err), but it passedmodule.exports.fetchas the second argument.Changes
Features
N/A
Bug Fixes
index-fetch.jsandindex.js: drop theconstructorOptargument so the stack keeps the callback frame and the caller's async frames:test/fetch/client-error-stack-trace.jsthat loadsindex-fetch.jsin a module wrapper without__filename, as Node.js does, and checks that the caller appears in the stack. It fails onmain.Breaking Changes and Deprecations
N/A
Status