Repository navigation
Isolate prefill cohorts and support legacy DFlash image positions - #10
Conversation
Retain prompt logits until the prefill cohort completes and infer temporal-only M-RoPE for legacy DFlash drafts. Assisted-by: Codex
Pre-merge handoff — reviewed head
|
Keep test failure messages out of the positional strict argument checked by ty. Assisted-by: Codex
Work report — type-check failure corrected at current PR headOwner and scope: Codex root task, combined PR #10 for issues #5/#6. Exact published head: Why: GitHub Done and evidence: Replaced those two explicit failure paths with Remaining: Wait for the relevant current-head checks and review gate, then merge if permitted. Paired host/RPC installation and live native/proxy acceptance for PP/TG and Nex DFlash image/cache/text remain pending; both issues stay open. Next: Root coordinator retains merge, build/deployment, and behavior acceptance. |
Pre-merge handoff — exact head
|
Delivery report — merged; paired runtime acceptance remains openOwner and scope: Codex root task, issues #5/#6. PR #10 merged at reviewed head Evidence: The focused GCC 13 native build/server checks, CPU allocator/RoPE/sampler and server regressions, cache/text controls, independent source review, Remaining: No installed native binaries were changed by this PR delivery step. The root coordinator still owns paired host/RPC build and installation at the proxy-selected paths, manifest/process verification, and live unequal-prompt PP/TG plus Nex DFlash cold-image, media/cache continuation, and text acceptance. Do not close #5 or #6 before those deployed checks pass. Next: Root coordinator continues paired deployment and model/proxy acceptance on the merged source revision. |
Overview
The native server currently lets completed prompts enter token generation while other slots are still prefilling, and a legacy DFlash draft can reject image-following text positions from an M-RoPE target. This change adds a scheduler phase barrier for admitted prompts and infers the missing temporal-only M-RoPE metadata for compatible legacy drafts.
Addresses #5
Addresses #6
Additional information
For phase scheduling, compatible requests may join the PP cohort until its first member completes PP. That completion seals membership; early finishers retain their final logits and wait. TG starts only after every cohort member completes or terminates, and later PP waits until that TG cohort drains. The policy applies to streaming and non-streaming generation. This keeps the phase boundary explicit while allowing a short prompt to wait behind a longer one; an unlimited TG cohort can therefore delay later prefill.
For legacy DFlash, the binary infers temporal-only M-RoPE sections from a target that declares M-RoPE sections only when the draft has no explicit sections. Explicit draft metadata, text-only targets, and DSV4 remain unchanged. Invalid rotary dimensions fail closed before draft-context initialization. No model tensor or GGUF artifact is modified.
Focused validation passed on the combined GCC 13 build:
llama-server, allocator (53 cases/345 assertions), RoPE and sampler checks; five phase/barrier cases; fourn_probsvariants; speculative parity with and without a draft; per-request and incompatible-group LoRA cases; four borrowed-snapshot cases; stream/non-stream equivalence; and a cache/no-cache continuation control. The cache/no-cache case was unskipped only in an out-of-source test wrapper. Python syntax andgit diff --checkpassed. These CPU/local checks do not establish paired V100/RPC runtime behavior.The remaining acceptance is to install the matching host and RPC binaries at the proxy-selected paths and verify live unequal-prompt PP/TG scheduling plus the Nex legacy-DFlash cold image, media/cache continuation, and text behavior through the current route. Issues remain open until that deployed behavior passes.
The implementation and focused tests were assisted by Codex. The owner authorized and reviewed the integrated candidate and remains responsible for the submitted changes; see AGENTS.md and CONTRIBUTING.md.
Requirements