Repository navigation
bench: fix multi-step Flash fixture padding - #14
Merged
Merged
Conversation
Track the inserted padding directly so follow-up token probes extend the pad instead of slicing from the question text. Add a regression for prompts that require multiple padding steps. Assisted-by: Codex
Owner
Author
Validation update for
|
7 of 21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes generated fixture preparation when more than one padding step is needed. Padding is inserted before the final question, so it must be tracked directly; slicing the rendered content after the base prompt length can take text from the question instead of the accumulated padding. The regression test covers the multi-step case.
Addresses #9
Validation
python3 -m unittest -v tests.test_bench_flash_next(14 tests passed)flake8withflake8-no-printon the two changed filesgit diff --checkThis is a correctness fix for benchmark preparation and makes no inference performance claim.
Requirements