bugfix: Prevent arborist from changing protocols as part of resolve step#5256
Closed
Aeolun wants to merge 1 commit into
Closed
bugfix: Prevent arborist from changing protocols as part of resolve step#5256Aeolun wants to merge 1 commit into
Aeolun wants to merge 1 commit into
Conversation
Aeolun
force-pushed
the
bugfix/use-specified-resolution-protocol
branch
from
7bd8fc5 to
d7b405a
Compare
Author
|
This doesn't actually work. I will resubmit when I know what the issue is. |
owlstronaut
pushed a commit
that referenced
this pull request
Jun 19, 2026
This prevents changing URLs from `https` and `git+https` into `git+ssh`, but keeps the fall-back to `git+ssh` when the protocol is not specified. The change in [pacote](npm/pacote#434) is necessary in order to have this fully working. ## References Supersedes #5256 Blocked by npm/pacote#434 Fixes #4305 Fixes #2610 Signed-off-by: Oldřich Jedlička <oldium.pro@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents arborist from changing URL's that are specified as
git+httpsfrom being transformed intogit+sshregardless of whether or not authentication has been specified in thepackage.json.We shouldn't try to guess what the user intended. If they specify either
httpsorsshthen that's what will be used.Details
This uses a fix roughly based on a suggestion by @denenr in #4305. I've also taken the liberty of cleaning up the humongous nested ternary statement.
Fixes #4305
Fixes #2610