fix(arborist): don't flag inert optional deps in strict-allow-scripts#9602
Merged
Conversation
…#9597) Fixes #9562. `strict-allow-scripts` walked the ideal tree and rejected inert optional deps like `fsevents` on Linux, even though reify removes them before any install script runs. The shared `collectUnreviewedScripts` walk now skips inert nodes, so the strict check matches what actually installs. `approve-scripts` (actual tree) was already correct. (cherry picked from commit 7655822)
owlstronaut
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9597 to
release/v11.