fix(allowScripts): close three enforcement gaps#9652
Merged
owlstronaut merged 3 commits intoJun 25, 2026
Merged
Conversation
nishantms
reviewed
Jun 25, 2026
nishantms
reviewed
Jun 25, 2026
nishantms
reviewed
Jun 25, 2026
JamieMagee
force-pushed
the
jamiemagee/allowscripts-enforcement-fixes
branch
from
8ce994c to
83bdb35
Compare
owlstronaut
approved these changes
Jun 25, 2026
Contributor
|
This usually means the cherry-pick had conflicts. Please create a manual backport: git fetch origin release/v11
git checkout -b backport/v11/9652 origin/release/v11
git cherry-pick -x 60d0d3d7c4c8b394b4a35b18f138439d75308368
# resolve any conflicts, then:
git push origin backport/v11/9652Error details |
owlstronaut
pushed a commit
that referenced
this pull request
Jun 25, 2026
…11) (#9663) Backport of #9652 to `release/v11`. Two adaptations versus latest: - `link.js`: dropped the `patchRelaxOpts`/`cli-only-flag` lines, which only exist on latest. The global-install policy gating and strict preflight are kept. - Omitted the bundled-dependency regression test. v11's rebuild gate is deny-only (blocks on `isScriptAllowed === false`), so a bundled dep (null verdict) is not blocked there and the test would not hold. The version-pinned deny fix and the `npm link` global-install gating both apply and are tested. Changed source keeps 100% coverage on `script-allowed.js`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three allowScripts (install-script policy) fixes:
resolved.npm link <pkg>gates the global install of a missing package.