Skip to content

ci(generate-api-reference): Fix printing step for larger logs - #19

Merged
papazof merged 1 commit into
mainfrom
ci_strict_check_generate_api_reference
Jun 4, 2025
Merged

papazof merged 1 commit into
mainfrom
ci_strict_check_generate_api_reference

Conversation

@papazof

@papazof papazof commented May 17, 2025 •

Copy link
Copy Markdown
Contributor

Use a heredoc instead of using the env in the printing step of generate-api-reference. This way JSON is read correctly and there is no limitation for the log length.

@papazof
papazof force-pushed the ci_strict_check_generate_api_reference branch 12 times, most recently from fe674d6 to 16e080c Compare May 18, 2025 05:48
@papazof papazof changed the title ci(generate-api-reference): Add strict check for generated files ci(generate-api-reference): Fix printing step for larger logs May 18, 2025
@papazof
papazof force-pushed the ci_strict_check_generate_api_reference branch from 16e080c to bf08c22 Compare May 18, 2025 05:57
@papazof
papazof marked this pull request as ready for review May 18, 2025 18:13
@papazof
papazof requested a review from ananos May 18, 2025 18:13

@ananos ananos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @papazof

Use a heredoc instead of using the env in the printing step of
`generate-api-reference`. This way JSON is read correctly and there is
no limitation for the log length.

PR: #19
Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com>
Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk>
Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
@github-actions
github-actions Bot force-pushed the ci_strict_check_generate_api_reference branch from bf08c22 to fb505c3 Compare June 4, 2025 19:23
@vaccel-bot vaccel-bot Bot added ok-to-test and removed ok-to-test labels Jun 4, 2025
@github-actions

github-actions Bot commented Jun 4, 2025

Copy link
Copy Markdown

Coverage report diff

Filename Stmts Miss Cover
TOTAL 0 0 +100.00%

@papazof
papazof merged commit f4dcc4d into main Jun 4, 2025
@papazof
papazof deleted the ci_strict_check_generate_api_reference branch June 4, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants