Repository navigation
chore(deps): upgrade comark to 0.9.1 - #613
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On comark 0.7, saving a Docus page that repeats a heading inside a component, such as
::code-preview, wrote an explicit id like{#titles-1}into the file. comark 0.9.1 includes the fix (comarkdown/comark#578).What changed
^0.9.1inpackage.jsonand thepnpm-workspace.yamloverride.inlineCode: falseto shiki ingenerate.tsandtiptapToComark.ts. comark 0.9 highlights inline code, which throwsShikiError: Theme 'github-dark' not foundwith Studio's string theme names.linkify: falsewithregisterDefaultPlugins: falseand the other default plugins, ingenerate.tsandai/completion.ts.:brwhen a trailing-space break wouldn't round-trip, so the file no longer changes on save.Evidence
New test:
## Titlesat the top level and inside::code-preview, read through@nuxtjs/mdcand saved from the editor.## Titles {#titles-1}pnpm lint(0 errors),pnpm prepack,pnpm typecheckandpnpm test(448/448) pass.ELI5
Studio uses a library to read and write Markdown. The old version added odd markers to some headings when you saved a page. The new version fixes that, and these changes adapt Studio to how the new version works.
🤖 Generated with Amp, reviewed by @larbish before opening.