Repository navigation
feat(utils): add streaming sitemap parsers - #635
Merged
Merged
Conversation
Parse URL sets and sitemap indexes from Response.body with bounded buffers and cancellation when consumers stop early. Keep the regular parser fast with a direct path for common URL entries. BREAKING CHANGE: parseSitemapXml now returns an empty result for a well-formed empty urlset instead of throwing.
commit: |
harlan-zw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Related to #634
❓ Type of change
📚 Description
Large sitemap feeds currently buffer the response and build a full
fast-xml-parsertree before callers can cap results.parseSitemapStreamacceptsResponse.body, reports the document kind before entries, and cancels unread bytes when iteration stops. A direct fast path moves the 10,000 URL regular parser benchmark from 74.8 ms to 6.8 ms.A well-formed empty
<urlset>now returns{ urls: [], warnings: [] }fromparseSitemapXmlinstead of throwing.📝 Migration
Remove wrappers that identify empty URL sets from parser error messages. Handle an empty
urlsarray directly.