Repository navigation
fix(mcp): authenticate tool calls per HTTP request - #2134
Merged
Merged
Conversation
tmt-123
requested review from
AlexStocks,
PsiACE,
frostming and
zhanghuidinah
as code owners
October 20, 2026 14:07
hidb4ai
reviewed
Oct 20, 2026
hidb4ai
left a comment
Contributor
There was a problem hiding this comment.
One reproducible test-isolation issue remains in the TCP server lifecycle; details inline.
Contributor
Author
|
Fixed in 80928b9. Updated the test server to leave process signal handling to pytest and removed the manual AppStatus reset. Added regression coverage for delayed restarts and overlapping listeners. |
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue or RFC does this PR close?
Closes #2082.
Rationale for this change
Stateful MCP execution retains the initializing HTTP request's authentication context. Another authenticated caller can reuse the session and execute tools under the creator's identity. Actor and group membership also remain stale across requests.
What changes are included in this PR?
Are there any user-facing changes?
MCP no longer issues transport session IDs. Clients should reconnect after upgrading. Scope, Memory, and Handoff data remain persisted. Cross-request SSE stream resumption is unavailable.
How was this change tested?
AI usage statement
OpenAI Codex assisted with implementation, regression tests, and validation.