Skip to content

fix(projects): stop deletion when cleanup fails - #106

Draft
alichherawalla wants to merge 1 commit into
codex/f2-app-restartfrom
codex/f3-project-cleanup
Draft

alichherawalla wants to merge 1 commit into
codex/f2-app-restartfrom
codex/f3-project-cleanup

Conversation

@alichherawalla

@alichherawalla alichherawalla commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Recovered outcome

A project stays available when its knowledge cleanup fails. The Projects screen now explains the refusal instead of appearing to ignore the delete action.

Scope

  • Return one typed delete outcome from the Desktop project IPC boundary.
  • Keep the selected project when the SQLite cleanup transaction fails.
  • Show the returned reason in the existing Projects surface.
  • Add a real SQLite refusal check and a rendered failure-state integration check.

Passed checks

  • Live development flow: created and deleted F3 Live Cleanup through the rendered Projects surface in an isolated profile.
  • npm run test:db -- src/main/__tests__/rag-ipc-project-create.dbtest.ts: 3 passed.
  • Rendered Projects refusal integration: 1 passed.
  • Focused ESLint: 0 errors; 6 existing preload warnings.
  • Diff and formatting checks passed.
  • CodeRabbit passed or skipped review because this PR is draft.

Open gates

  • Desktop node and web typechecks remain blocked by existing Shared/model/RAG interface drift in models-manager.ts, rag/index.ts, rag/store.ts, and setup.ts.
  • Hosted CI failed at the same core typecheck gate and did not run later checks.
  • The production and packaged Desktop builds were not run because the typecheck gate is open.
  • The live refusal-state run did not finish because the existing startup/navigation surface was unstable; the real SQLite and rendered integration checks passed separately.
  • Visual inspection is open because this recovery task prohibits Computer Use.

This PR must remain draft while these required gates are open.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant