Repository navigation
Conversation
akiltipu
marked this pull request as ready for review
October 5, 2026 18:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy project does not build natively for arm64 with the selected toolchain. After enabling arm64, Bengali suggestions appeared on macOS 27 but committing with Space or clicking a candidate inserted nothing. LLDB captured
-[__NSSingleObjectArrayI insertText:replacementRange:]: unrecognized selector: the cached client was stale, while InputMethodKit's current client was valid.This keeps the existing Objective-C application and makes a small product change:
[self client]for candidate/delimiter insertion.Parser rules, dictionaries, UI resources, dependencies and deployment settings are unchanged. The current SDK supplies an inherited deployment target of 27.0; no lower-OS runtime support is claimed. This branch targets arm64 only.
Validation
./scripts/check.sh: eight controller cases, 15 exact UTF-8 snapshots captured from unchanged upstream parser/rules, packaged resources, SQLite integrity, ICU/dictionary lookup and autocorrect checks PASS. The controller harness fails against unchanged upstream as expected.The PR adds isolated tests and a nonprivileged ARM64 GitHub Actions workflow. Remote CI is pending its first run. Fork-specific branding/release documents are excluded.
Review boundaries
This is an Objective-C alternative to the broader changes currently in #2 and #3, whose heads include the Swift migration. No commits were copied from those forks.
Release runtime, preference/learning persistence, clean-account registration, full rollback and notarized/downloaded-artifact tests remain NOT TESTED. A public binary is not included. Credits states MPL 1.1 for the application, but clarification is still needed for the exact scope covering dictionaries/rules and NSString+Levenshtein. A further inspection of the original RTF hyperlink confirms CC BY 3.0 for the Dortmund icons. Existing notices are preserved; this PR does not assign new terms to inherited material.
Fork-specific prerelease preparation is separate: akiltipu#1. That branch replaces the historical distance routine; it is not part of this smaller compatibility PR.