Repository navigation
suppress ansi output for all terminal commands when ansi terminal not available. #147
Description
We already have some code that suppresses ansi output when running on a none ansi device.
We need to review the terminal library to see if we can do further suppression so that the code 'mostly' works when on non-ansi devices.
With methods like write we could try to track row movements and if the row has moved since the last write then we add a newline before doing the next output.
The problem with this idea is that we would possible need to 'intercept' calls to print so we know when it has changed the row.
things to ponder.
Activity
passsy commentedon Jun 1, 2021
Can't we trust
stdin.supportsAnsiEscapes?bsutton commentedon Jun 1, 2021
passsy commentedon Jun 2, 2021
I don't like the idea of
green(String)automatically detecting if ansi is supported and eventually apply the ansi color code. That could cause hard to detect bugs.But
dclicould offer alternative methods of doing just that. i.e.eventuallyGreen(String).Similarly,
askcould return the default value ifstdinisn't available.Another option could be a stdout filter, removing all ansi escape sequences. This could become a great interceptor api allowing filtering of different logging levels beyond
--verbose.bsutton commentedon Jun 2, 2021
Have a read of #149
Methods like 'green(String)' are already suppressing colour output if ansi is not supported. If you look at $149 the improvements on whether ansi is supported have actually had what is (in my opinion) an undesirable outcome.
I'm not certain I'm keen on the idea of a stdout filter, i'm not even certain how we would implement it (may be a guarded zone).
I do like your idea for the ask function as the ask function is a problem in unit tests and having some mode that auto returns the default seems rather useful.
GitBook: [#147] updated Format.row to Format.row()