Repository navigation
fix: build with Go 1.26.10 for the eMudhra CA distrust - #5
Merged
Merged
Conversation
monit-reviewer
approved these changes
Oct 21, 2026
monit-reviewer
left a comment
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: c86ba25b98c2
Profile: claude-monit-reviewer - Posting as: monit-reviewer
Summary
| Reviewer | Findings |
|---|---|
| automation:ci-deploy | 0 |
| security:code-auditor | 0 |
Reviewer Coverage
automation:ci-deploy— complete (broad); skipped: none; constraints: Only .github/workflows/ci.yml references a Go version (go-version-file: go.mod); no release workflow or goreleaser config was found in the checkout.security:code-auditor— complete (broad); skipped: none; constraints: Could not independently verify that Go 1.26.10 contains the CVE-2026-111943 fix; relied on the PR description. Release builds use a shared reusable workflow (release.yml) that was not inspected; could not confirm it honors the go.mod toolchain directive.
Inspected files (1)
go.mod
0 PR discussion threads considered. 0 summarized; 0 resolved.
Completed in 3m 06s | ~$0.68 (est.) | claude-sonnet-5-5 | cr 0.10.325
| Field | Value |
|---|---|
| Model | claude-sonnet-5-5 |
| Reviewers | automation:ci-deploy, security:code-auditor |
| Engine | claude_cli · claude-sonnet-5-5 |
| Reviewed by | cr · monit-reviewer |
| Duration | 3m 06s wall · 4m 03s compute |
| Cost | ~$0.68 (est.) |
| Pricing basis | baseline-2026-10-02/pricing |
| Tokens | 28 in / 3.3k out |
Per-workstream usage
orchestrator-selection— claude-sonnet-5-5- In: 4
- Out: 532
- Cache read: 9.2k
- Cache create: 33.2k
- Cost: ~$0.14 (est.)
- Duration: 13s
automation:ci-deploy— claude-sonnet-5-5- In: 10
- Out: 1.2k
- Cache read: 107.0k
- Cache create: 33.1k
- Cost: ~$0.17 (est.)
- Duration: 1m 15s
security:code-auditor— claude-sonnet-5-5- In: 8
- Out: 1.1k
- Cache read: 82.4k
- Cache create: 32.6k
- Cost: ~$0.16 (est.)
- Duration: 1m 29s
orchestrator-rollup— claude-sonnet-5-5- In: 6
- Out: 460
- Cache read: 90.7k
- Cache create: 48.3k
- Cost: ~$0.22 (est.)
- Duration: 1m 05s
zzwong
marked this pull request as ready for review
October 21, 2026 00:47
Pin the Go toolchain to 1.26.10, which distrusts the compromised eMudhra intermediate keys (CVE-2026-111943), and read the Go version from go.mod in every setup-go step.
zzwong
force-pushed
the
zzwong/go-1.26.10-toolchain
branch
from
October 21, 2026 00:53
c86ba25 to
553f190
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
toolchain go1.26.10to every Go module so CI and release builds use Go 1.26.10. Go 1.26.10 and 1.27.3 add acrypto/x509distrust of the compromised eMudhra intermediate keys (CVE-2026-111943), which applies whatever root store the binary verifies against. Binaries built with earlier releases still accept certificates issued through those keys on Linux, where verification uses the system roots.actions/setup-gouses thetoolchaindirective in preference to thegodirective, so builds, tests and releases all pick it up. Thegolanguage version is unchanged.Verification
GOTOOLCHAIN=go1.26.10 go build ./...passes for every module.