Repository navigation
fix(release): write the cask postflight as install steps - #6
Merged
Merged
Conversation
The release workflow installs GoReleaser `~> v2`, which now resolves to
2.19. That version deprecates `homebrew_casks.hooks.post.install`, and the
workflow's `goreleaser check` fails on any deprecated property, so the
next release would fail before building.
Move the postflight to `install_steps` with `{{ .StagedPath }}`.
GoReleaser renders it as a `postflight_steps` block with the absolute
`{{staged_path}}` token, which the shared modernizer passes through
unchanged. GoReleaser pins in workflows move to v2.19.0, which reads
`install_steps`.
Twapp-Session: f18916e9-4ebc-4371-a3db-eb58d9daed7d
monit-reviewer
approved these changes
Oct 28, 2026
monit-reviewer
left a comment
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: d0a4cb443beb
Profile: claude-monit-reviewer - Posting as: monit-reviewer
Summary
| Reviewer | Findings |
|---|---|
| harness-engineering:repo-health | 0 |
| policies:conventions | 0 |
| automation:ci-deploy | 0 |
Reviewer Coverage
Complete coverage details are retained in the local coverage.json artifact.
harness-engineering:repo-health— complete (constrained); scope: 1 file; examples:.goreleaser.yml; body-inspected: 1 file; examples:.goreleaser.yml; skipped: none; constraints: Diff is a single 2-line change in .goreleaser.yml; goreleaser was not run, so the install_steps rendering was not verified locally. PR text says workflow pins move to v2.19.0, but no workflow files are in the changed set (the release workflow appears to be a shared external one), so that part was not reviewed.policies:conventions— complete (constrained); scope: 1 file; examples:.goreleaser.yml; body-inspected: 1 file; examples:.goreleaser.yml; skipped: none; constraints: GoReleaser 2.19 rendering of install_steps was not executed; relied on PR description. Only .goreleaser.yml diff reviewed; workflow GoReleaser version pins mentioned in the PR description are not in the assigned file scope.automation:ci-deploy— complete (broad); scope: 1 file; examples:.goreleaser.yml; body-inspected: 1 file; examples:.goreleaser.yml; skipped: none; context (not coverage): 1 file; examples:.github/workflows/release.yml; constraints: Did not run goreleaser; relied on the PR's stated check/snapshot verification that hooks.post.install_steps is accepted by 2.19.0 and renders postflight_steps. Diff only changes .goreleaser.yml; the PR description's GoReleaser pin bump to v2.19.0 lives in the shared reusable workflow (open-cli-collective/.github release.yml@v1), which is not in this repo and was not inspected.
0 PR discussion threads considered. 0 summarized; 0 resolved.
Completed in 1m 14s | ~$0.29 (est.) | claude-sonnet-5-5 | cr 0.10.351
| Field | Value |
|---|---|
| Model | claude-sonnet-5-5 |
| Reviewers | harness-engineering:repo-health, policies:conventions, automation:ci-deploy |
| Engine | claude_cli · claude-sonnet-5-5 |
| Reviewed by | cr · monit-reviewer |
| Duration | 1m 14s wall · 1m 59s compute |
| Cost | ~$0.29 (est.) |
| Pricing basis | baseline-2026-10-02/pricing |
| Tokens | 34 in / 4.6k out |
Per-workstream usage
orchestrator-selection— claude-sonnet-5-5- In: 4
- Out: 625
- Cache read: 4.8k
- Cache create: 10.9k
- Cost: ~$0.05 (est.)
- Duration: 12s
harness-engineering:repo-health— claude-sonnet-5-5- In: 8
- Out: 1.1k
- Cache read: 32.4k
- Cache create: 14.0k
- Cost: ~$0.07 (est.)
- Duration: 33s
policies:conventions— claude-sonnet-5-5- In: 6
- Out: 804
- Cache read: 26.6k
- Cache create: 10.0k
- Cost: ~$0.05 (est.)
- Duration: 23s
automation:ci-deploy— claude-sonnet-5-5- In: 10
- Out: 1.6k
- Cache read: 62.4k
- Cache create: 14.0k
- Cost: ~$0.08 (est.)
- Duration: 40s
orchestrator-rollup— claude-sonnet-5-5- In: 6
- Out: 452
- Cache read: 40.2k
- Cache create: 4.0k
- Cost: ~$0.03 (est.)
- Duration: 9s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release workflow installs GoReleaser
~> v2, which now resolves to 2.19. That version deprecateshomebrew_casks.hooks.post.install, and the workflow'sgoreleaser checkfails on any deprecated property, so the next release would fail before building.install_stepswith{{ .StagedPath }}. GoReleaser renders it as apostflight_stepsblock with the absolute{{staged_path}}token, which the shared alias job's modernizer passes through unchanged.install_steps.Verification
goreleaser checkwith 2.19.0 passes for.goreleaser.yml; onmainit fails with the deprecation.goreleaser release --snapshot --clean --skip=publish,before,sign,validaterenders each cask'spostflight_stepsblock asrun "/usr/bin/xattr", args: ["-dr", "com.apple.quarantine", "{{staged_path}}/<binary>"].Model: Claude Opus 5.5 (1M context, xhigh effort) in Claude Code.