Skip to content

feat: ResolveAll endpoint for bulk evaluation - #239

Merged
james-milligan merged 26 commits into
open-feature:mainfrom
james-milligan:resolve-all
Jan 12, 2023
Merged

james-milligan merged 26 commits into
open-feature:mainfrom
james-milligan:resolve-all

Conversation

@james-milligan

Copy link
Copy Markdown
Contributor

This PR

  • introduces the resolve all endpoint for bulk flag evaluation

Related Issues

#234

Notes

Follow-up Tasks

How to test

Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan

Copy link
Copy Markdown
Contributor Author

LINTING FIXES:
Added the //nolint:funlen annotation to the Notify function of Kubernetes_sync.go. To drop the functions lines by 2 we will need to abstract out functionality that is used once, or drop comments. Both options will make the code more confusing for developers.

@james-milligan
james-milligan marked this pull request as ready for review December 21, 2022 15:00
Comment thread pkg/eval/json_evaluator.go
@toddbaert
toddbaert self-requested a review January 3, 2023 15:08
@toddbaert

Copy link
Copy Markdown
Member

I tested this and it works as expected. I agree with @skyerus that it might be nice to reduce some duplication, but that may not be possible.

james-milligan and others added 2 commits January 4, 2023 11:10
Signed-off-by: James Milligan <james@omnant.co.uk>
@beeme1mr
beeme1mr requested a review from skyerus January 4, 2023 16:09
Signed-off-by: James Milligan <james@omnant.co.uk>
@beeme1mr beeme1mr linked an issue Jan 5, 2023 that may be closed by this pull request
3 of 4 tasks
james-milligan and others added 6 commits January 6, 2023 09:38
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Comment thread pkg/eval/json_evaluator.go Outdated
Comment thread pkg/service/connect_service.go Outdated
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
james-milligan and others added 2 commits January 6, 2023 15:24
Signed-off-by: James Milligan <james@omnant.co.uk>
james-milligan and others added 4 commits January 10, 2023 15:23
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan
james-milligan merged commit 6437c43 into open-feature:main Jan 12, 2023
james-milligan pushed a commit that referenced this pull request Jan 12, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.3.1](v0.3.0...v0.3.1)
(2023-01-12)


### Features

* file extension detection
([#257](#257))
([ca22541](ca22541))
* ResolveAll endpoint for bulk evaluation
([#239](#239))
([6437c43](6437c43))


### Bug Fixes

* **deps:** update module github.com/bufbuild/connect-go to v1.4.1
([#268](#268))
([712d7dd](712d7dd))
* **deps:** update module github.com/mattn/go-colorable to v0.1.13
([#260](#260))
([5b11504](5b11504))
* **deps:** update module github.com/open-feature/open-feature-operator
to v0.2.23 ([#261](#261))
([a1dd3b9](a1dd3b9))
* **deps:** update module github.com/rs/cors to v1.8.3
([#264](#264))
([0e6f2f3](0e6f2f3))
* **deps:** update module github.com/stretchr/testify to v1.8.1
([#265](#265))
([2ec61c6](2ec61c6))
* improve invalid sync URI errror msg
([#252](#252))
([5939870](5939870))
* replace character slice with regex replace
([#250](#250))
([c92d101](c92d101))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
raphael-wigoutschnigg-dt pushed a commit to open-feature-forking/flagd that referenced this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] flagd bulk evaluation

3 participants