fix: include proto file in build for openfeature-provider-flagd - #45
Merged
Conversation
Signed-off-by: Federico Bond <federicobond@gmail.com>
toddbaert
approved these changes
Feb 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
===========================================
- Coverage 90.55% 71.04% -19.52%
===========================================
Files 8 10 +2
Lines 180 297 +117
===========================================
+ Hits 163 211 +48
- Misses 17 86 +69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
Author
|
@toddbaert damn, hatch requires python 3.9+. I have to go now, but feel free to edit this PR |
gruebel
reviewed
Feb 22, 2024
gruebel
left a comment
gruebel
left a comment
Member
There was a problem hiding this comment.
I found a similar solution, but yours seems better 😄
Member
the plugin requires Python 3.9 😢 |
Member
No worries! Bummer about 3.8... Looks like it isn't eol until October... Not sure we should drop early, but that's an option. |
federicobond
force-pushed
the
fix-build
branch
from
February 23, 2024 13:47
d0206b4 to
d09e9b5
Compare
Signed-off-by: Federico Bond <federicobond@gmail.com>
federicobond
force-pushed
the
fix-build
branch
from
February 23, 2024 13:50
d09e9b5 to
8e8ff2e
Compare
beeme1mr
approved these changes
Feb 23, 2024
gruebel
approved these changes
Feb 23, 2024
jonathannorris
added a commit
that referenced
this pull request
Jun 22, 2026
Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
jonathannorris
added a commit
that referenced
this pull request
Jul 20, 2026
Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
toddbaert
pushed a commit
that referenced
this pull request
Jul 31, 2026
Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
toddbaert
added a commit
that referenced
this pull request
Jul 31, 2026
* chore: resolve open dependabot security alerts - aiohttp 3.13.5 -> 3.14.1 (medium, alerts #34, #35) Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * chore: bump cryptography to 49.0.0 to resolve dependabot alert #45 Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * chore: bump grpcio to 1.81.1 to match generated grpc code Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * chore: pin grpcio-tools to match runtime grpcio version Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * chore: bump pinned grpcio-tools to 1.82.1 to match relocked grpcio runtime Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * chore: align build-time protobuf pin with grpcio-tools 1.82 requirement grpcio-tools 1.82+ dropped protobuf 6.x support and now requires protobuf>=7.35.1,<8.0.0, so the isolated build hook's protobuf pin must track the runtime protobuf constraint instead of staying on ~=6.0 (see #400 for why it was pinned there originally). Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * fixup: minor updates, group grpcio deps Signed-off-by: Todd Baert <todd.baert@dynatrace.com> --------- Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com> Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #44. hatch now generates the proto client files during the build stage.
We can probably find a cleaner solution later.