Skip to content

fix(playwright): replace flaky toast assertion with search-based deletion verification in teams & teams drag drop spec #27341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harsh-vador merged 6 commits into from
Apr 15, 2026
+13 −11
Merged

fix(playwright): replace flaky toast assertion with search-based deletion verification in teams & teams drag drop spec #27341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5eac75e
fix(playwright): replace flaky toast assertion with search-based dele…
harsh-vador Apr 14, 2026
54de560
address gitar
harsh-vador Apr 14, 2026
8069288
Merge branch 'main' into remove-toast-assertions-teams-spec
harsh-vador Apr 14, 2026
3725b49
address comments
harsh-vador Apr 14, 2026
7bf8142
Merge branch 'main' into remove-toast-assertions-teams-spec
harsh-vador Apr 14, 2026
1bc77f1
Merge branch 'main' into remove-toast-assertions-teams-spec
harsh-vador Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/TeamsDragAndDrop.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ test.describe(

await waitForAllLoadersToDisappear(page);

await hardDeleteTeam(page);
await hardDeleteTeam(page, teamName);

// Validate the deleted team
await expect(
Expand Down
9 changes: 6 additions & 3 deletions openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Teams.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ test.describe('Teams Page', () => {
teamDetails?.updatedName ?? ''
);

await hardDeleteTeam(page);
await hardDeleteTeam(page, teamDetails?.updatedName ?? teamDetails.name);
});
});

Expand Down Expand Up @@ -501,7 +501,10 @@ test.describe('Teams Page', () => {
team.responseData?.['displayName']
);

await hardDeleteTeam(page);
await hardDeleteTeam(
page,
team.responseData?.['displayName'] ?? team.data.name
);
await afterAction();
});

Expand Down Expand Up @@ -765,7 +768,7 @@ test.describe('Teams Page', () => {
page.getByTestId('team-hierarchy-table').getByRole('link')
).toContainText(team2Details.displayName);

await hardDeleteTeam(page);
await hardDeleteTeam(page, team1Details.name);
});

test('Total User Count should be rendered', async ({ page }) => {
Expand Down
13 changes: 6 additions & 7 deletions openmetadata-ui/src/main/resources/ui/playwright/utils/team.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import {
assignDomain,
descriptionBox,
redirectToHomePage,
toastNotification,
uuid,
} from './common';
import {
Expand Down Expand Up @@ -133,12 +132,11 @@ export const softDeleteTeam = async (page: Page) => {

await page.click('[data-testid="confirm-button"]');

await deleteResponse;

await toastNotification(page, /deleted successfully!/);
const response = await deleteResponse;
expect(response.status()).toBe(200);
};

export const hardDeleteTeam = async (page: Page) => {
export const hardDeleteTeam = async (page: Page, teamName: string) => {
await page
.getByTestId('team-details-collapse')
.getByTestId('manage-button')
Expand All @@ -159,9 +157,10 @@ export const hardDeleteTeam = async (page: Page) => {

await page.click('[data-testid="confirm-button"]');

await deleteResponse;
const response = await deleteResponse;
expect(response.status()).toBe(200);

await toastNotification(page, /deleted successfully!/);
await searchTeam(page, teamName, { expectEmptyResults: true });
};

export const getNewTeamDetails = (teamName: string) => {
Expand Down
Loading