fix(appMode): also preserve a fresh cross-tab hint through the AuthProvider hydrate

openmetadata-ui/src/main/resources/ui/src/components/Auth/AuthProviders/AuthProvider.tsx

@@ -65,6 +65,8 @@
 import { useApplicationStore } from '../../../hooks/useApplicationStore';
 import {
   clearAppMode,
+  isAppModeHintFresh,
+  readAppModeHint,
   readAppModeSession,
   resolveEffectiveAppMode,
   resolveInitialAppMode,
@@ -162,16 +164,27 @@
   const appDefault = translateWireMode(appConfig?.defaultAppMode ?? null);
   setAppDefaultMode(appDefault);
 
-  // If this tab already has a session tuple (a manual toggle earlier in
-  // this tab, or a reload of one) leave it alone. `useResolvedAppMode`
-  // is the authoritative source and treats the tuple as the highest-
-  // priority signal once persona information is available — writing
-  // here would clobber a valid in-tab choice with the boot-time best-
-  // effort resolve (which cannot yet see persona) and break "toggle to
-  // AI, then reload" for users who did not tick "remember".
+  // Skip the boot-time write when this tab already has a signal that
+  // `useResolvedAppMode` will resolve authoritatively — the resolver is
+  // the single source of truth once it has persona + registry
+  // information, and writing to the session tuple here poisons the
+  // subsequent resolve. Two signals count:
+  //
+  //   1. A session tuple this tab already owns (returning tab, or a
+  //      manual toggle earlier in this tab).
+  //   2. A fresh cross-tab `omAppModeHint` — the mechanism by which a
+  //      sibling tab's active mode carries into a newly-opened tab.
+  //      Once we write `DEFAULT_APP_MODE` here, the resolver's session-
+  //      tuple check is satisfied by our write and it never consults
+  //      the hint, so a cmd+click from an AI tab silently boots the new
+  //      tab into Classic.
   if (readAppModeSession()?.mode) {
     return;
   }
+  const hint = readAppModeHint();
+  if (isAppModeHintFresh(hint) && hint?.mode) {
+    return;
+  }
 
   const userPref =
     derivePreferencesFromList(prefsRes.preferences).appMode ?? null;
@@ -246,7 +259,7 @@
 
   const clientType = authConfig?.clientType ?? ClientType.Public;
 
   const onLoginHandler = () => {
     setApplicationLoading(true);
 
     let attempts = 0;
@@ -323,7 +336,7 @@
 
     // Upon logout, redirect to the login page
     navigate(ROUTES.SIGNIN);
   }, [timeoutId]);
 
   const handledVerifiedUser = () => {
     if (!applicationRoutesClass.isProtectedRoute(location.pathname)) {
@@ -381,7 +394,7 @@
     });
   }, []);
 
   const resetUserDetails = (forceLogout = false) => {
     setCurrentUser({} as User);
     clearOidcToken();
     setIsAuthenticated(false);
@@ -463,7 +476,7 @@
       // After every refresh success, start timer again
       tokenService.current.updateRefreshSuccessCallback(startTokenExpiryTimer);
     }
   }, [authenticatorRef.current?.renewIdToken]);
 
   // When the tab becomes visible after being backgrounded, browsers may have
   // throttled or suspended the proactive renewal timer. Check token freshness
@@ -506,7 +519,7 @@
     return () => {
       document.removeEventListener('visibilitychange', handleVisibilityChange);
     };
   }, []);
 
   /**
    * Performs cleanup around timers
@@ -516,7 +529,7 @@
     clearTimeout(timeoutId);
   }, [timeoutId]);
 
   const handleFailedLogin = () => {
     setIsSigningUp(false);
     setIsAuthenticated(false);
     setApplicationLoading(false);
@@ -574,7 +587,7 @@
         setApplicationLoading(false);
       }
     },
     [
       authConfig?.enableSelfSignup,
       clientType,
       authorizerConfig?.principalDomain,
@@ -619,7 +632,7 @@
    * Initialize Axios interceptors to intercept every request and response
    * to handle appropriately. This should be called only when security is enabled.
    */
   const initializeAxiosInterceptors = async () => {
     // Axios Request interceptor to add Bearer tokens in Header
     if (requestInterceptor != null) {
       axiosClient.interceptors.request.eject(requestInterceptor);
@@ -687,26 +700,26 @@
               }
               isRefreshDriverActive = true;
 
               const drainPendingRequests = (hasNewToken: boolean) => {
                 const queued = pendingRequests;
                 pendingRequests = [];
                 isRefreshDriverActive = false;
                 if (hasNewToken) {
                   queued.forEach(
                     ({ resolve: onResolve, reject: onReject, config }) =>
                       axiosClient
                         .request(config)
                         .then(onResolve)
                         .catch(onReject)
                   );
                 } else {
                   queued.forEach(({ reject: onReject }) => onReject(error));
                 }
               };
 
               tokenService.current
                 .refreshToken()
                 .then(async (token) => {
                   if (token) {
                     await initializeAxiosInterceptors();
                     drainPendingRequests(true);