Skip to content

fix(playwright): Fixed article test, added search before asseting on the article card - #31616

Merged
Rohit0301 merged 2 commits into
mainfrom
context-center-article-flaky
Aug 17, 2026
Merged

Rohit0301 merged 2 commits into
mainfrom
context-center-article-flaky

Conversation

@Rohit0301

@Rohit0301 Rohit0301 commented Aug 17, 2026 •

Copy link
Copy Markdown
Contributor

Describe your changes:

Fixes #

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • For UI changes: I attached a screen recording and/or screenshots above.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

Greptile Summary

This PR stabilizes the article persistence Playwright scenario by searching for the updated article before asserting that its card is visible.

  • Adds article searches after returning to the article list.
  • Keeps the existing saved-title and unsaved-edit persistence assertions unchanged.

Confidence Score: 5/5

The PR appears safe to merge with no established actionable issues.

The changes only filter the article list before existing visibility assertions, and no concrete test failure or lost coverage is established.

Important Files Changed

Filename Overview
openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ContextCenterArticles.spec.ts Adds targeted searches before two article-card visibility checks; no concrete actionable defect was established.

Reviews (1): Last reviewed commit: "lint fix" | Re-trigger Greptile

@Rohit0301 Rohit0301 self-assigned this Aug 17, 2026
@Rohit0301 Rohit0301 added the safe to test Add this label to run secure Github workflows on PRs label Aug 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions github-actions Bot added the UI UI specific issues label Aug 17, 2026
@ShaileshParmar11
ShaileshParmar11 added this pull request to the merge queue Aug 17, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 17, 2026
@Rohit0301
Rohit0301 added this pull request to the merge queue Aug 17, 2026
Merged via the queue into main with commit c06c4ac Aug 17, 2026
76 of 79 checks passed
@Rohit0301
Rohit0301 deleted the context-center-article-flaky branch August 17, 2026 20:53
@gitar-bot

gitar-bot Bot commented Aug 17, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Updates the Playwright article test to perform a search before asserting on the article card, resolving flakiness. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

This branch was previously deployed

1 inactive deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants