Repository navigation
fix consumer: my-pv ACThor/Elwa-E - #4051
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The reviewed changes consistently use the supported Modbus API and appropriate integer encoding.
Review effort: Lite
Findings: None
What changed in this PR
Fixes Modbus power-limit writes for the my-PV Acthor and Elwa-E consumers.
Changes:
- Replaces unsupported
write_registerscalls with typedwrite_registercalls. - Converts power limits to integer
INT16values.
| File | Description |
|---|---|
packages/modules/consumers/my_pv/elwa_e/consumer.py |
Fixes Elwa-E register writes. |
packages/modules/consumers/my_pv/acthor/consumer.py |
Fixes Acthor register writes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
LKuemmel
requested changes
Oct 7, 2026
LKuemmel
left a comment
LKuemmel
left a comment
Contributor
There was a problem hiding this comment.
In den Mustern unter docs/samples gibt es bei den Verbrauchern auch noch Aufrufe von client.write_registers. Kannst Du die bitte auch noch korrigieren?
Samples angepasst auf write_register
Collaborator
Author
ist erledigt :) |
LKuemmel
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write_register statt nicht existierendem write_registers
#3656 (comment)