ci: add unified variant to PR Preview Build - #1301
Merged
Merged
Conversation
Found while testing PR #1297 (telegram allowed_users): triggering PR Preview Build with variant=default builds openab with its default Cargo features (discord/slack/secrets-aws/agentcore/config-s3/ pre-seed) - telegram/line/feishu/wecom/googlechat/teams are NOT in that list, they only compile in via the 'unified' feature. The resulting preview image ran fine but had no webhook server at all for any of those platforms - every request returned 503 with no logs, since the whole #[cfg(feature = "telegram")]-gated code path was absent from the binary. Wasted a full deploy+test cycle before tracing it back to the Dockerfile's BUILD_MODE default. Add 'unified' as a variant choice, resolved to the same base Dockerfile as 'default' but with BUILD_MODE=unified passed as a docker build-arg, matching what the real release pipeline (build-operator.yml) uses via a different (Dockerfile.unified) mechanism for the multi-agent-variant builds - this workflow only supports the legacy single Dockerfile, so BUILD_MODE=unified is the correct way to get the same Cargo-feature set here. Produces the same ghcr.io/openabdev/openab:pr<N> tag as 'default' (same image name/suffix, different feature set baked in) - no new tag pattern introduced. Not run through CI (workflow_dispatch-only, can't be exercised by 'changes'/'check' path-filter jobs) - verified by re-triggering it for PR #1297 with variant=unified immediately after this commit and confirming the resulting image actually starts the telegram webhook server (see PR #1297 conversation for the live verification).
Collaborator
Author
|
LGTM ✅ — Clean CI workflow enhancement, already verified by run #139. What This PR DoesAdds a How It Works
Findings
Baseline Check
What's Good (🟢)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 'unified' as a variant choice in pr-preview.yml so preview builds can include all platform features (telegram, line, feishu, wecom, googlechat, teams).
Verified by run #139 against PR #1297.