Repository navigation
fix(scan): restore omitted target and scope metadata - #1083
Merged
Merged
Conversation
ianw-oai
marked this pull request as ready for review
September 28, 2026 20:45
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ianw-oai
commented
Sep 28, 2026
3 tasks done
Merged
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A Standard scan can finish its analysis, then fail to save when the agent omits
scan.targetorscan.scope. Completion now creates those objects and fills them from the registered workbench metadata.Changes
inventoryStrategyremains required; there are no net schema, report, or SDK changes.Related: #828 handles an incorrect authored kind but still requires the target object to exist. This change does not replace explicit kinds.
Testing
build:ci,types, andformatpassed, including generated-model checks.git diff --checkpassed.120d9fdb, retaining only the target and scope fixes againstmain.Risk and rollout
No public CLI or coverage-schema changes. Only unsealed drafts with a workbench completion binding get missing target and scope metadata. Sealed hashes, invalid explicit kinds, malformed objects, and required-coordinate checks keep their existing behavior. Ambiguous registered kinds are not inferred. A missing scan object or findings array remains a validation error.
Verification used synthetic local fixtures, not a live model scan. The fix needs a release before CLI users receive it.
Public disclosure review