Skip to content

ci: reuse native builds across package and container checks - #1130

Merged
mldangelo-oai merged 3 commits into
mainfrom
mdangelo/codex/ci-build-reuse
Oct 1, 2026
Merged

mldangelo-oai merged 3 commits into
mainfrom
mdangelo/codex/ci-build-reuse

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Build native payloads once per automatic CI run and share them between package checks and the amd64/arm64 container checks. This removes duplicate native builds on main and duplicate amd64 container builds on affected pull requests.

Changes

  • Make node-ci the automatic caller of the shared two-architecture container validator. Keep container-ci as a manual entry point.
  • Move its unique Docker exclusion and noninteractive discovery checks into the shared validator. Keep validation available to forks.
  • Require selected container checks to pass through the existing Unix CI results.
  • Cache the Windows pnpm store by lockfile; continue building native binaries within each run.

Testing

  • 29 focused container/skeleton tests passed. Their JUnit report has 29 unique case identities and passes the existing report comparator. Parameterized titles render booleans explicitly so retargeted and unchanged-base cases remain distinct.
  • All 292 release-automation tests, SDK types/format, actionlint, and diff checks passed.
  • Combined with the companion CI changes: workflow linters and 327 integration tests passed. The tests cover the shared job graph, retained checks, fork behavior, change selection, and failure handling.
  • Hosted native builds, artifact assembly, and package verification passed. Hosted CI exercises both container architectures.
  • Three independent native reviews and a fresh verification pass found no actionable regressions.

Risk and rollout

Every main push now validates both container architectures. A container failure blocks automatic release cutting. Pull requests still skip unrelated container work, and required check names remain unchanged. Release publication keeps its own build and verification steps.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-30T18:58:51.433873Z 1b1e923 New commits
🔒 Security Review ✅ Completed 2026-09-30T18:59:49.539535Z 1b1e923 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@soyeon-oai soyeon-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed same-run artifact reuse, retained container checks, fork validation scope, and release/required-check dependencies. No actionable findings. Inspected successful hosted native/container results for both architectures; no independent test execution.

@mldangelo-oai
mldangelo-oai merged commit 3f1b673 into main Oct 1, 2026
69 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/ci-build-reuse branch October 1, 2026 20:07
@github-actions github-actions Bot mentioned this pull request Oct 1, 2026
3 tasks done
@mldangelo-oai
mldangelo-oai requested a balanced review from Copilot October 1, 2026 20:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The workflow consolidation preserves validation coverage and is supported by targeted tests.

Review effort: Balanced
Findings: None

What changed in this PR

Reuses native artifacts across package and container CI while consolidating container validation.

Changes:

  • Routes automatic container checks through node-ci.
  • Moves unique checks into the shared amd64/arm64 validator.
  • Adds Windows pnpm caching and workflow coverage.
File Description
.github/​workflows/​node-ci.yml Integrates and gates shared container validation.
.github/​workflows/​container-ci.yml Retains a manual validation entry point.
.github/​workflows/​container-validate.yml Adds shared exclusion and discovery checks.
.github/​workflows/​native-windows.yml Enables lockfile-based pnpm caching.
sdk/​typescript/​tests-ts/​container-ci-workflow.test.ts Tests workflow selection, reuse, and failure gating.
sdk/​typescript/​tests-ts/​skeleton.test.ts Updates expected required-job dependencies.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants