Repository navigation
ci: reuse native builds across package and container checks - #1130
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
soyeon-oai
left a comment
There was a problem hiding this comment.
Reviewed same-run artifact reuse, retained container checks, fork validation scope, and release/required-check dependencies. No actionable findings. Inspected successful hosted native/container results for both architectures; no independent test execution.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The workflow consolidation preserves validation coverage and is supported by targeted tests.
Review effort: Balanced
Findings: None
What changed in this PR
Reuses native artifacts across package and container CI while consolidating container validation.
Changes:
- Routes automatic container checks through
node-ci. - Moves unique checks into the shared amd64/arm64 validator.
- Adds Windows pnpm caching and workflow coverage.
| File | Description |
|---|---|
.github/workflows/node-ci.yml |
Integrates and gates shared container validation. |
.github/workflows/container-ci.yml |
Retains a manual validation entry point. |
.github/workflows/container-validate.yml |
Adds shared exclusion and discovery checks. |
.github/workflows/native-windows.yml |
Enables lockfile-based pnpm caching. |
sdk/typescript/tests-ts/container-ci-workflow.test.ts |
Tests workflow selection, reuse, and failure gating. |
sdk/typescript/tests-ts/skeleton.test.ts |
Updates expected required-job dependencies. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Summary
Build native payloads once per automatic CI run and share them between package checks and the amd64/arm64 container checks. This removes duplicate native builds on main and duplicate amd64 container builds on affected pull requests.
Changes
node-cithe automatic caller of the shared two-architecture container validator. Keepcontainer-cias a manual entry point.Testing
Risk and rollout
Every main push now validates both container architectures. A container failure blocks automatic release cutting. Pull requests still skip unrelated container work, and required check names remain unchanged. Release publication keeps its own build and verification steps.
Public disclosure review