Skip to content

fix(cli): organize and clarify command help - #1142

Merged
mldangelo-oai merged 5 commits into
mainfrom
mdangelo/codex/cli-help
Oct 1, 2026
Merged

mldangelo-oai merged 5 commits into
mainfrom
mdangelo/codex/cli-help

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

CLI help mixes common commands, advanced settings, and framework options in long lists. Group commands by task and make command help easier to follow with examples, readable value labels, and accurate defaults.

Changes

  • Group root commands by workflow and add a short quickstart. Group scan and publish scan options by purpose.
  • Wrap descriptions to terminal width while preserving copyable commands and paths. Clarify repeatable flags, patch prerequisites, file imports, and export formats.
  • Show output controls only where supported, and clarify that CSV input requires internal publication. Keep existing parsing and publication behavior.
  • Check public argument and option coverage against command schemas, and include the help formatter in the npm package.

Testing

  • After merging main: 435 focused help, schema, provider, redaction, authentication, and patch tests passed. pnpm run types, pnpm run format, and pnpm run build:ci passed.
  • Two independent native reviews and fresh verification completed with no findings on the merged commit.
  • Before the main merge, both full SDK runs on 5f1bccd passed: 3,303 tests passed, 51 skipped, and no failures in each run.
  • Full reruns after the merge were stopped after disk exhaustion caused ENOSPC while copying the native test executable and a SQLite disk I/O error. These runs did not complete; hosted CI must validate the merged commit.
  • The package build and installed-package smoke passed for the help formatter's packaging changes before this main merge.

Risk and rollout

Human-readable help changes layout and wording. Command syntax, accepted values, defaults, and routing remain compatible; schema descriptions reflect the updated copy. The formatter depends on the pinned Incur help layout, covered by help and packaging tests.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the bug Something isn't working label Oct 1, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-01T19:28:24.751026Z 5234bdf Manual request
🔒 Security Review ✅ Completed 2026-10-01T19:27:36.789075Z 5234bdf New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@soyeon-oai soyeon-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the help formatter, output-routing boundary, packaging allowlist, and help/schema tests. The formatting gate preserves structured output and command/option rows. No actionable findings. Hosted node-ci passed; I did not independently run tests.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 22292e3698

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Public CSV publication guidance is internally inconsistent, and argument completeness is not actually tested.

Review effort: Balanced
Findings: 2 Medium severity

Open (2)
What changed in this PR

Reorganizes CLI help around common workflows with clearer labels, examples, wrapping, and documentation.

Changes:

  • Adds a dedicated help formatter with grouped commands and options.
  • Clarifies command descriptions, examples, defaults, and value labels.
  • Expands help presentation and package coverage.
File Description
sdk/​typescript/​src/​cli-help.ts Formats and groups generated help.
sdk/​typescript/​src/​cli.ts Adds revised help text and examples.
sdk/​typescript/​tests-ts/​cli-help.test.ts Tests formatting, routing, and widths.
sdk/​typescript/​tests-ts/​cli.test.ts Expands command help checks.
sdk/​typescript/​tests-ts/​cli-skills.test.ts Updates semantic value expectations.
sdk/​typescript/​tests-ts/​cli-scan-import.test.ts Updates import file labels.
sdk/​typescript/​tests-ts/​cli-cloud-publish.test.ts Updates CSV label expectation.
sdk/​typescript/​scripts/​check-package.mjs Includes the formatter in package checks.
sdk/​typescript/​README.md Documents the reorganized help.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread sdk/typescript/src/cli-help.ts
Comment thread sdk/typescript/tests-ts/cli.test.ts
@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The formatter is comprehensively tested and preserves existing CLI parsing and behavior.

Review effort: Balanced
Findings: None

Resolved since last review (2)

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f42aaf724c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread sdk/typescript/src/cli-help.ts Outdated
@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5f1bccd98a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread sdk/typescript/src/cli-help.ts

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The help-only changes are coherent, comprehensively tested, and preserve existing CLI behavior.

Review effort: Balanced
Findings: None

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

@mldangelo-oai
mldangelo-oai requested a balanced review from Copilot October 1, 2026 19:25
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 5234bdfc6e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The help-only changes are cohesive, comprehensively tested, and preserve existing CLI routing and behavior.

Review effort: Balanced
Findings: None

@mldangelo-oai
mldangelo-oai merged commit 03da500 into main Oct 1, 2026
57 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/cli-help branch October 1, 2026 20:07
@github-actions github-actions Bot mentioned this pull request Oct 1, 2026
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants