[mldangelo-oai]

Part 43 of 46. Previous: #1165 · Next: #1167 · Stack index

Summary

Delete the old Deep Scan coordinator, registry and state store after plugin execution has moved to the SDK.

Changes

• Remove their direct lifecycle, deadline, publication and worker-failure test fixtures.

Testing

Checks against the complete stack passed: SDK and MCP typechecks, formatting, Ruff, the SDK build, portable plugin compatibility and its tests, focused recovery/accounting tests, and local-artifact package smoke using exact cached dependencies. The package check was not a clean registry install. See this PR’s Checks tab for CI results for its current commit.

Risk and rollout

The plugin entrypoint already uses the SDK runner. This PR only deletes the retired coordinator implementation and its tests.

Public disclosure review

• No customer, partner, prospect, or user identities, data, or identifying details are included.
• No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
• I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

[mldangelo-oai]

@codex review

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	⚠️ Failed 2026-10-04T17:32:48.392641Z	b94940c	Draft marked ready
🔒 Security Review	⚠️ Failed 2026-10-04T17:32:48.964087Z	b94940c	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 9379491de9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[Copilot]

Copilot review overview

🟢 Approval recommended

The deleted modules have no remaining references, and corresponding behavior is covered by the active SDK implementation and tests.

Review effort: Balanced
Findings: None

What changed in this PR

Removes the retired plugin-side Deep Scan coordinator and persistence store after execution migrated to the SDK.

Changes:

• Deletes coordinator, registry, and store implementations.
• Removes their lifecycle, deadline, publication, failure, and persistence tests.
• Leaves active SDK-based Deep Scan execution unchanged.

File	Description
src/​deep-scan/​coordinator.ts	Removes legacy coordination logic.
src/​deep-scan/​registry.ts	Removes legacy coordinator registry.
src/​deep-scan/​store.ts	Removes legacy workbench store.
tests/​deep_scan_deadline_cases.mjs	Removes coordinator deadline tests.
tests/​deep_scan_publication_cases.mjs	Removes coordinator publication tests.
tests/​deep_scan_worker_failure_cases.mjs	Removes coordinator failure tests.
tests/​test_deep_scan_store.mjs	Removes legacy store tests.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[faizan-oai]

Reviewed the retired coordinator/store deletion at 0e7cbd9. The SDK/native replacements remain wired, and integrated typechecking, plugin build, and native lifecycle checks pass. No new issue found in this cleanup increment.

[alandelong-oai]

Three independent passes found no actionable regression in the legacy coordinator/store deletions. Root validation on this exact head passed a clean SDK build, MCP type checking, plugin bundling, and the diff check. No repository files were changed.

[alandelong-oai]

The previously completed three independent passes carry forward after verifying the patch is identical; root reconciled the current base and discussion.

No serious outstanding finding was identified in this change. The scoped prior review and current diff remain consistent.

Approval is for this change. Integrated-tip validation passed 1,357 SDK tests (31 skipped), 105 MCP tests (2 skipped), portable checks, types/builds and installed-package smoke. Other stack findings and known CI fixture failures still prevent the stack from being mergeable.

[alandelong-oai]

Re-reviewed the real PR diff at 062de440a7b8926af140dfb77a6d49cb49f1ab3c. The patch is unchanged from the prior three-pass review. I reconciled the inherited changes in touched files and retained the prior verified findings and tests.

No serious outstanding finding identified in this patch; prior conclusions remain consistent with the unchanged change or the current re-review.

Validation across touched paths at branch tip 06e75cfe: 1,356 SDK tests, 867 Python tests plus 100 subtests, and 108 MCP tests passed; builds, types, portable checks and installed-package checks passed. These are integration checks at the branch tip, not a claim that every intermediate PR or its CI is clean. Current CI still contains failed, canceled, or pending checks; this review does not establish merge readiness.

[alandelong-oai]

Retained the three independent passes for the identical patch and reconciled inherited touched-file changes at 32ffaf02f6ad.

No actionable introduced finding survives the independent reviews and root reconciliation of this exact patch, touched-file changes, and current integration checks.

Current tip 355ec321 passed 75 report-projection tests, portable source checks, SDK build:ci and plugin build. The immediately preceding tip fec36f1d passed 1,360 SDK tests, 873 Python tests plus 100 subtests, 109 MCP tests, builds/types and the clean 600-entry installed-package check. Only report_projection.py and its test changed between those tips; SDK/MCP runtime files are byte-identical. Both descend from main 008a8b4d. These are integration checks, separate from own-head probes. No native Windows local run.

No serious outstanding finding introduced by this PR. Code review approval does not establish CI or merge readiness.

[alandelong-oai]

Retained the three independent passes for the verified identical patch and reconciled inherited touched-file changes at 0f32f2f13101.

No actionable introduced finding survives the independent reviews and root reconciliation of this exact patch and inherited changes in touched files.

Integrated tip 6ef8cbb8, based on 008a8b4d, passed 1,388 SDK tests, 879 Python tests plus 100 subtests, 109 MCP tests, portable checks, builds and the clean 600-entry installed-package check. These are branch-tip integration checks, separate from own-head probes; no local Windows execution was performed.

No serious outstanding finding introduced by this PR. Code approval is separate from CI and merge readiness.

[alandelong-oai]

Retained three prior independent passes for the verified identical patch and reconciled inherited touched-file changes at 50443415d6fd.

No actionable introduced finding survives the independent reviews and root reconciliation of this exact patch and inherited changes in touched files.

Branch tip 3e0083d9, based on 008a8b4d, passed 1,392 SDK tests, 881 Python tests plus 100 subtests, 109 MCP tests, builds, portable source checks and the 600-entry installed-package check. These are tip checks, separate from own-head probes. No local Windows run was performed. The tip excludes the dependency update merged separately in #1184; combined validation remains outstanding.

No serious outstanding finding introduced by this PR. Code approval is separate from CI and merge readiness.