Repository navigation
feat: support per-scan Cyber access programs - #1185
Merged
Merged
Conversation
3 tasks done
mldangelo-oai
marked this pull request as ready for review
October 2, 2026 02:10
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Base automatically changed from
mdangelo/codex/cyber-access-dependencies
to
main
October 2, 2026 03:31
kmbroai
approved these changes
Oct 2, 2026
kmbroai
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed API-key program selection, saved resume settings, and fresh/resumed Deep Scan propagation. The focused worker-launch and read-only helper tests passed locally; full CI passed on this head. Production entitlements were not exercised. No blocking findings.
Merged
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
API-key scans can select a Cyber access program without dropping it before the API request. The same selection reaches fresh and resumed Deep Scan workers, automatic component planning, and finding matching.
Fixes #1024. Uses the dependency update merged in #1184.
Changes
--cyber-access-program standard|daybreak_blue|daybreak_redtoscanandscan-components, SDKcyberAccessProgram, and project settingscan.cyber_access_program. All are optional and omitted by default.Testing
pnpm run test --seed 12345andpnpm run test. Cross-platform results are recorded in the PR checks.Merge validation (
46a046b882): merged currentmain, retained per-scan isolation assertions alongside the updated promise helper, and passed all five portable plugin checks, SDK types/formatting, the Deep Scan executor tests, and focused Cyber/authentication/concurrency tests. Fresh cross-platform CI passed with 56 successful checks and 4 skipped checks, including code and security review. One macOS runner DNS failure during Node setup cleared on retry. The local full-suite attempt was stopped after host-specific filesystem fixture failures; full-suite validation came from CI.Risk and rollout
Uses the Codex prerelease dependency already present on
main. Omission preserves existing defaults. Selection is supported by the built-in OpenAI provider; server-side entitlements still apply. QA did not exercise production entitlements.Public disclosure review