Repository navigation
refactor(native): remove unused OS primitives and proofs - #1192
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
6d18c5a to
db68016
Compare
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Removed symbols have no remaining repository callers, and the identified diagnostic wording issue is non-blocking.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Removes obsolete native OS primitives and their proofs while retaining operations used by the plugin.
Changes:
- Removes unused Unix and Windows native APIs and flags.
- Simplifies platform proofs and Windows CI.
- Updates native binding types and documentation.
| File | Description |
|---|---|
.github/workflows/native-windows.yml |
Removes retired lock interoperability step. |
plugins/codex-security/native/README.md |
Documents retained native functionality. |
plugins/codex-security/native/binding.mts |
Narrows the Unix binding to account lookup. |
plugins/codex-security/native/proof-windows.mts |
Removes proofs for retired Windows operations. |
plugins/codex-security/native/proof.mts |
Retains only Unix account-lookup proofs. |
plugins/codex-security/native/src/unix.rs |
Removes unused Unix primitives. |
plugins/codex-security/native/src/windows.rs |
Removes unused Windows operations. |
plugins/codex-security/native/windows-binding.mts |
Narrows Windows binding interfaces. |
plugins/codex-security/native/windows-flags.mts |
Removes unused constants. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kmbroai
left a comment
There was a problem hiding this comment.
Reviewed the native API removals and retained callers. Rust formatting, SDK CI compilation, portable source checks, and all nine compatibility-checker tests pass locally. The complete native, platform, and package CI run now passes on this head; native rebuild coverage is from CI. No blocking findings.

Summary
Remove unused native OS primitives and their primitive-only proofs after their production callers were migrated. Retain the native operations used by the supported CLI, SDK, and plugin.
Changes
This PR contains only the native portion of the original cleanup: nine files, 60 additions, and 1,149 deletions. It targets main independently of the MCP and SDK cleanup PRs.
Testing
On the latest native commit:
git diff --checkpassed; removed primitives have no production callers on main.Risk and rollout
No public commands, flags, accepted values, environment variables, or defaults change. Existing credential, unsafe-path, scan-integrity, and worker settings protections remain in place. The complete native platform and package-install CI matrix must pass for this standalone head before merging.
Public disclosure review