Repository navigation
fix(plugin): include server-rendered templates in scan inventories - #1197
Merged
mldangelo-oai merged 2 commits intoOct 3, 2026
Merged
Conversation
mldangelo-oai
approved these changes
Oct 3, 2026
mldangelo-oai
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for catching this gap. These templates can contain application code and output-escaping decisions, so including them in the filtered inventories and rank inputs is the right behavior. The existing sampled preview is sufficient; no template execution or new parser is needed.
I simplified the coverage by extending the existing template integration tests and removing duplicated Git setup and preview-budget cases. The production fix remains three extension entries. All 15 new cases fail without those entries, and the final focused suite passes all 242 tests. The required portable source checks also pass.
The change is small, useful, and ready to merge. Thanks for the contribution!
Merged
3 tasks done
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EJS, ERB, and PHTML files were omitted from canonical diff inventories and repository/diff rank inputs because their suffixes were missing from the shared file-type list. These templates can contain application code and security-sensitive output, so they belong in scan coverage.
Changes
.ejs,.erb, and.phtmltoTEXT_CODE_EXTENSIONS, using existing sampled-text previews..html.erbnames across repository, revision, and local-patch inputs.Testing
pnpm --dir sdk/typescript run build:ci: passed.Risk and rollout
The production change is three entries in the existing shared extension list. Existing exclusions, binary and symlink handling, and preview budgets continue to apply. Templates are read as source, never rendered or executed. Whole-repository canonical inventory already includes these files; this fixes the filtered paths. No CLI changes or migration are required.
Public disclosure review