Skip to content

refactor(tooling): share repository Git adapters - #1203

Merged
mldangelo-oai merged 1 commit into
mainfrom
refactor/pr1185-followup-03-git
Oct 3, 2026
Merged

mldangelo-oai merged 1 commit into
mainfrom
refactor/pr1185-followup-03-git

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Oct 3, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Repository fixtures and hydration tools duplicate Git process setup. Share the existing invocation patterns with their actual consumers.

Changes

  • Add a typed Git text adapter for MCP and SDK fixture consumers.
  • Reuse Git execution in hydration and release tooling while preserving stderr and stdin handling.

Testing

Release-PR tests passed (73 cases), along with hydration and Git fixture checks. Release-automation warning failures passed after disabling ambient proxy warnings. All five portable source checks and SDK/MCP typechecks passed.

Risk and rollout

Git output, exit failures and raw diagnostics retain their current behavior. This supplies the fixture dependency used by the runtime follow-up.

This patch has no source prerequisite within the series. Squash-merge it into main after review and checks pass. Before retargeting dependent PRs to main, rebase them onto main excluding this branch’s old pre-squash commits and rerun their checks.

Direct follow-ups: #1207.

When integrating with #1206, retain both the Git adapter and temporary-directory helper imports in test_compact_artifact_server.mjs.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

Repository fixtures and hydration tools duplicate Git process setup. Share the existing invocation patterns with their actual consumers.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-03T20:24:31.489513Z 3807571 Manual request
🔒 Security Review ✅ Completed 2026-10-03T19:29:10.053022Z 3807571 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review the current head 3807571.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The narrow refactor preserves existing Git execution behavior, with no unresolved blocking issues.

Review effort: Balanced
Findings: None

What changed in this PR

Consolidates Git invocation helpers across repository tooling and fixtures, providing the shared fixture dependency for the SDK follow-up.

Changes:

  • Adds a typed Git text adapter for MCP and SDK consumers.
  • Reuses Git execution in release and hydration tooling while preserving output, stdin, stderr, and failure behavior.
File Description
sdk/​typescript/​tests-ts/​support/​shell.ts Re-exports the Git adapter.
sdk/​typescript/​tests-ts/​release-pr.test.ts Uses the adapter for blob creation.
sdk/​typescript/​tests-ts/​git-fixture.ts Shares fixture Git execution.
sdk/​typescript/​scripts/​release-pr.mjs Uses the adapter for release operations.
plugins/​codex-security/​mcp-app/​tests/​test_mcp_app_smoke.mjs Uses the adapter to read commit IDs.
plugins/​codex-security/​mcp-app/​tests/​test_compact_artifact_server.mjs Shares fixture Git execution.
plugins/​codex-security/​mcp-app/​scripts/​git.mjs Adds the UTF-8 Git adapter.
plugins/​codex-security/​mcp-app/​scripts/​git.d.mts Declares adapter types.
evals/​triage-finding/​scripts/​hydrate-calibration-repos.js Reuses the hydration Git helper.
evals/​triage-finding/​sastbench/​scripts/​hydrate-sastbench-repos.js Exports the helper with configurable stderr.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 3807571306

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@alandelong-oai alandelong-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3807571306e706884d831acc5825ae4a707d6810 against its own base 3642a76a53173e012f579737d1b6cf4096379af2 with exactly three independent high-reasoning full-diff reviews, including every test diff, plus root verification. No serious introduced code defect identified.

73 focused SDK tests and both complete affected MCP test scripts passed; fresh native host build, plugin/SDK builds, types, formatting, Ruff and portable source checks passed.

Local validation was on macOS arm64. No model execution, local Windows run or full installed-package smoke. Reviewed sources remained unchanged. This review covers this exact head; it does not establish combined-stack validation against current main.

@mldangelo-oai
mldangelo-oai merged commit f49a9a5 into main Oct 3, 2026
115 checks passed
@mldangelo-oai
mldangelo-oai deleted the refactor/pr1185-followup-03-git branch October 3, 2026 22:05
@github-actions github-actions Bot mentioned this pull request Oct 3, 2026
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants