Repository navigation
fix(plugin): inherit Deep Scan worker service tiers - #1238
Conversation
…/codex/qa-worker-fast-mode # Conflicts: # plugins/codex-security/mcp-app/tests/test_deep_scan_executor.ts
…/codex/qa-worker-fast-mode
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5ab806fda1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…/codex/qa-worker-fast-mode
…/codex/qa-worker-fast-mode
alandelong-oai
left a comment
alandelong-oai
left a comment
There was a problem hiding this comment.
Reviewed the full contribution at c3eab51711d83e892c263fdc543c5625e4c2b3ab with selected base 1345ea3fa48021ef54ecc2dcc948fde43fec8d0c, including changed tests and touched context, using three independent reviews followed by root synthesis.
No supported introduced finding.
Static source review; tests were inspected but not executed. CI, mergeability and integration are separate.
2 participants
Summary
Deep Scan workers omitted an existing
service_tierfrom the SDK-generated runtime configuration. Forward the resolved tier to fresh and resumed discovery and reducer workers.Changes
Testing
At the final head merged with main at
1345ea3f: Ruff lint/format, SDKbuild:ci, portable plugin compatibility, and all nine compatibility checker tests passed.SDK bundle, types, and formatting checks passed.
Final API and artifact-export regressions passed: 184 tests, four skips. Worker launch regressions passed for discovery, reduction, resumes, and concurrent tiers.
C++ ranking regressions passed: 212 tests. All six UTF-8 artifact-export regressions passed.
Three fresh native review passes and an independent verifier completed without findings.
Full SDK suite with seed 12345 passed: 3,570 tests, 53 skips, zero failures. Randomized full SDK order also passed with the same counts. These full orders preceded the final UTF-8 export merge; its focused checks passed above.
Three fresh native reviews and independent verification passed for the exact final head;
git diff --checkpassed.Risk and rollout
This forwards an existing setting from the SDK runtime snapshot without changing commands, flags, accepted values, or defaults. Concurrent scans retain separate snapshots. Native parent-session profile discovery and support for legacy embedded profile syntax remain upstream behavior; the dotted-profile regression verifies SDK projection and worker arguments.
Public disclosure review