Repository navigation
fix(release): wait for npm registry visibility - #1239
Merged
Merged
Conversation
…ease-registry-wait
…ease-registry-wait
mldangelo-oai
marked this pull request as ready for review
October 5, 2026 14:51
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…/codex/qa-release-registry-wait
…/codex/qa-release-registry-wait
alandelong-oai
approved these changes
Oct 5, 2026
alandelong-oai
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the full contribution at 515a4daa1065d57bbdb14ab0e1412578076176df with selected base 1345ea3fa48021ef54ecc2dcc948fde43fec8d0c, including changed tests and touched context, using three independent reviews followed by root synthesis.
No supported introduced finding.
Static source review; tests were inspected but not executed. CI, mergeability and integration are separate.
Merged
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm can accept a publication before its registry exposes the new version. An immediate GitHub release lookup then fails with
E404. Wait for the requested version to become available before downloading and verifying the release archive.Changes
Testing
0.162.0-alpha.14, full SDK orders passed with seed12345and random seed117021954: each had 3,574 passes, 53 skips, and zero failures across 160 files.build:ci, types, formatting, Ruff checks and formatting, plugin source compatibility, its checker tests, andgit diff --checkpassed.Risk and rollout
The release wait changes GitHub release automation. A version that remains absent after ten minutes still fails and can use the documented retry flow. Archive integrity, release identity, and signed provenance verification remain enforced. No public CLI surface changes.
Public disclosure review