Repository navigation
fix(plugin): load helpers with Python safe path - #1240
Merged
Merged
Conversation
…/codex/qa-helper-safe-path
…/codex/qa-helper-safe-path
mldangelo-oai
marked this pull request as ready for review
October 5, 2026 14:51
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…/codex/qa-helper-safe-path
alandelong-oai
approved these changes
Oct 5, 2026
alandelong-oai
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the full contribution at 2dcf46fafc66ae79990a61dbdccc60397e382203 with selected base 1345ea3fa48021ef54ecc2dcc948fde43fec8d0c, including changed tests and touched context, using three independent reviews followed by root synthesis.
No supported introduced finding.
Static source review; tests were inspected but not executed. CI, mergeability and integration are separate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Directly launching the publication and severity helpers with Python safe-path isolation fails before their help or command handling because sibling modules cannot be imported. Both helpers now load their canonical scripts directory, matching the existing standalone helper bootstrap.
Changes
workbench_publication.pyandworkbench_severity.py.python -P --helpsubprocesses.Testing
1345ea3f: Ruff lint/format, SDKbuild:ci, types, format, plugin bundle, portable source compatibility, and all nine compatibility checker tests passed.git diff --checkpassed.Risk and rollout
This follows the neighboring helpers' import bootstrap and preserves command arguments, diagnostic output, and business behavior. No public CLI API changes or migration are required.
Public disclosure review