Skip to content

fix(plugin): load helpers with Python safe path - #1240

Merged
mldangelo-oai merged 4 commits into
mainfrom
mdangelo/codex/qa-helper-safe-path
Oct 5, 2026
Merged

mldangelo-oai merged 4 commits into
mainfrom
mdangelo/codex/qa-helper-safe-path

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Directly launching the publication and severity helpers with Python safe-path isolation fails before their help or command handling because sibling modules cannot be imported. Both helpers now load their canonical scripts directory, matching the existing standalone helper bootstrap.

Changes

  • Bootstrap sibling imports in workbench_publication.py and workbench_severity.py.
  • Exercise both helpers through real python -P --help subprocesses.

Testing

  • On the final branch merged with main at 1345ea3f: Ruff lint/format, SDK build:ci, types, format, plugin bundle, portable source compatibility, and all nine compatibility checker tests passed.
  • All five helper dry-run regressions, 212 preview/rank regressions, and all six UTF-8 artifact-export regressions passed.
  • The complete Python suite passed with safe-path isolation on the preceding alpha.14 merge: 1,607 passed, six skipped, and 162 subtests. The subsequent preview and export changes received the focused checks above.
  • Three fresh native Codex reviews and independent verification passed for the final head.
  • git diff --check passed.

Risk and rollout

This follows the neighboring helpers' import bootstrap and preserves command arguments, diagnostic output, and business behavior. No public CLI API changes or migration are required.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the bug Something isn't working label Oct 5, 2026
@mldangelo-oai
mldangelo-oai marked this pull request as ready for review October 5, 2026 14:51
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-05T15:31:25.624021Z 2dcf46f New commits
🔒 Security Review ✅ Completed 2026-10-05T15:32:28.095304Z 2dcf46f New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@alandelong-oai alandelong-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the full contribution at 2dcf46fafc66ae79990a61dbdccc60397e382203 with selected base 1345ea3fa48021ef54ecc2dcc948fde43fec8d0c, including changed tests and touched context, using three independent reviews followed by root synthesis.

No supported introduced finding.

Static source review; tests were inspected but not executed. CI, mergeability and integration are separate.

@mldangelo-oai
mldangelo-oai merged commit cbb4801 into main Oct 5, 2026
71 of 95 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/qa-helper-safe-path branch October 5, 2026 19:22
@github-actions github-actions Bot mentioned this pull request Oct 5, 2026
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants