Repository navigation
fix(exports): preserve split UTF-8 diagnostics - #1249
Merged
mldangelo-oai merged 3 commits intoOct 5, 2026
Merged
mldangelo-oai merged 3 commits into
mldangelo-oai merged 3 commits into
Conversation
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
mldangelo-oai
approved these changes
Oct 5, 2026
mldangelo-oai
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this fix. I reproduced the UTF-8 corruption with a real helper process; using the stream decoder is the right small change.
I simplified the regression coverage into two cases in the existing export test file. They deliver mixed ASCII and multibyte text one byte at a time and check both returned diagnostics and thrown errors. Both fail with the old decoder and pass with the fix, without the subprocess handshake and polling machinery.
All six export tests, types, and formatting pass. This is worth keeping; the broader SDK checks and CI will finish before merge.
Merged
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Export-helper diagnostics can be corrupted when stderr splits a UTF-8 character between pipe chunks. Decode the stream continuously so returned diagnostics and helper errors preserve the original text.
Changes
Testing
artifact-export.test.tspassed.pnpm run types,pnpm run format, plugin assembly, andgit diff --checkpassed.12345(3,536 passed, 36 failed) and random seed136913072(3,561 passed, 11 failed), with 53 skips each. The failures came from fixture permissions and enclosing Git markers in the local test environment.umask 022: 378 tests passed.NODE_NO_WARNINGS=1to suppress the Node proxy warning.Risk and rollout
Small decoding correction using the stream's existing support for split characters. No public interface changes. The regression tests use in-memory streams and restore the subprocess spy after each case.
Public disclosure review