Skip to content

fix(cli): preserve scan service tier for inline patches - #1274

Merged
mldangelo-oai merged 5 commits into
mainfrom
mdangelo/codex/fix-inline-patch-service-tier
Oct 5, 2026
Merged

mldangelo-oai merged 5 commits into
mainfrom
mdangelo/codex/fix-inline-patch-service-tier

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

scan --patch could omit the scan's resolved service tier when launching remediation. Inline patch executions now retain this setting alongside the existing model and reasoning effort.

Changes

  • Resolve the tier through the existing scan profile configuration and carry it into the remediation child process.
  • Retain the scan’s native default when the ambient Codex home requests a different tier, using the existing native default override.
  • Add subprocess regressions for explicit and selected-profile tiers, ambient tier settings, overlapping scans, and standalone patch compatibility.

Testing

  • A synthetic ambient-tier regression reproduced the native-default mismatch before the fix; 77 affected inline-patch, skill, and configuration tests passed afterward.
  • Full SDK suites with seed 12345 and randomized order each passed 3,576 tests with zero failures on the pinned alpha.14 dependency graph before the subsequent C++ preview and export-decoding updates and the native-default follow-up.
  • After the main merge to 1345ea3f, 195 export, configuration, and authentication tests passed, including all six export tests; 212 rank-preview and rank-input tests passed.
  • Python Ruff lint and formatting, SDK build:ci, plugin bundle build, plugin source compatibility and its tests, SDK types, and formatting passed.
  • Three fresh native review passes and independent verification passed for the exact final commit.

Risk and rollout

This preserves an existing scan setting through remediation. Public flags, accepted values, and defaults are unchanged. Standalone skill override restrictions, authentication, and sandbox behavior are preserved; tier selection remains isolated per scan.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the bug Something isn't working label Oct 5, 2026
@mldangelo-oai
mldangelo-oai marked this pull request as ready for review October 5, 2026 14:52
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-05T16:09:26.208018Z bc90ff7 New commits
🔒 Security Review ✅ Completed 2026-10-05T16:09:25.197969Z bc90ff7 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 08135ebec0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread sdk/typescript/src/cli.ts

@alandelong-oai alandelong-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the full contribution at bc90ff7df6e38358fcb641542cb8815239dce7a8 with selected base 1345ea3fa48021ef54ecc2dcc948fde43fec8d0c, including changed tests and touched context, using three independent reviews followed by root synthesis.

No supported introduced finding.

Static source review; tests were inspected but not executed. CI, mergeability and integration are separate.

@mldangelo-oai
mldangelo-oai merged commit 9e1b49e into main Oct 5, 2026
60 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/fix-inline-patch-service-tier branch October 5, 2026 17:45
@github-actions github-actions Bot mentioned this pull request Oct 5, 2026
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants