Repository navigation
fix(server): require JSON content types for mutations - #1277
Merged
Merged
Conversation
…ndings-json-bodies
mldangelo-oai
marked this pull request as ready for review
October 5, 2026 14:52
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…/codex/fix-findings-json-bodies
…/codex/fix-findings-json-bodies
alandelong-oai
approved these changes
Oct 5, 2026
alandelong-oai
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the full contribution at a2d643d7752d1487f8d7a8106d4c44dcb94fa9f5 with selected base 1345ea3fa48021ef54ecc2dcc948fde43fec8d0c, including changed tests and touched context, using three independent reviews followed by root synthesis.
No supported introduced finding.
Static source review; tests were inspected but not executed. CI, mergeability and integration are separate.
Merged
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The findings mutation endpoints parsed request bodies without checking their declared media type. Both endpoints now require
Content-Type: application/jsonand reject other or missing types with HTTP 400invalid_requestbefore parsing, embedding, or storage.Changes
POST /v1/bulk/findingsandPOST /v1/dedupe-groups.Testing
12345and a random seed: each had 3,576 passes, 53 skips, zero failures, and 69,655 assertions across 160 files.1345ea3f, all six artifact-export regressions and 212 preview/rank regressions passed. The findings implementation and its tests were unchanged by that merge.build:ci, plugin generation, Ruff lint/format, portable plugin compatibility, and all nine checker tests passed.git diff --checkpassed.Risk and rollout
Clients sending JSON without a content type, or using another media type, must send
Content-Type: application/jsonbefore rollout. Existing JSON clients and documented examples use this header. Case variations and charset parameters remain supported. This changes the HTTP body-format requirement; it adds no public CLI syntax or authentication mechanism. Follow the existing local-service and authenticated proxy deployment guidance.Public disclosure review