Repository navigation
fix(cli): send the app-server initialized notification - #1282
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
alandelong-oai
approved these changes
Oct 5, 2026
alandelong-oai
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the full contribution at 387ab61e49cdb3b17a2b2bf63bf8fc04651c21eb with selected base e4eff6521926241c1ad1df1bb6395b71135e56d3, including changed tests and touched context, using three independent reviews followed by root synthesis.
No supported introduced finding.
Static source review; tests were inspected but not executed. CI, mergeability and integration are separate.
Merged
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The skill command client sends the MCP notification name to Codex app-server after initialization. Send the app-server protocol's
initializednotification before login or thread creation.Changes
Testing
bun test --timeout 30000 --seed 12345 tests-ts/cli-skills.test.ts tests-ts/cli-authentication.test.ts: 201 passed, 0 failed, using an isolated trusted temporary checkout.pnpm run types,pnpm run format, andgit diff --check: passed.Risk and rollout
One production-line change; commands, options, permissions, and output remain compatible. The pinned app-server currently tolerates the old notification, so this corrects the protocol mismatch without claiming a current scan failure. Existing authentication and thread-flow tests cover ordering.
Public disclosure review