Repository navigation
fix(workbench): preserve saved results with non-UTF-8 artifact names - #1289
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
alandelong-oai
left a comment
There was a problem hiding this comment.
Reviewed the full contribution at f66471491ecb65fba567a3c7b5eef9987a1db35e with selected base e4eff6521926241c1ad1df1bb6395b71135e56d3, including changed tests and touched context, using three independent reviews followed by root synthesis.
No supported introduced finding.
Static source review; tests were inspected but not executed. CI, mergeability and integration are separate.
Summary
Keep saved scan views readable when a supplemental artifact has a filename that cannot be encoded as UTF-8.
Changes
Testing
build:ci, source compatibility, and all nine compatibility tests.git diff --checkpassed. Three fresh independent native reviews and verification passed.Risk and rollout
One production condition moves inside the existing error handler, which also catches filename encoding errors. Valid artifact paths retain their behavior; unencodable supplemental filenames are omitted from the optional artifact list. Existing containment, symlink, and portable-path checks remain in place. The arbitrary-byte filename case skips Windows and macOS; the normal artifact case remains enabled on both. No public CLI or configuration changes.
Public disclosure review