Skip to content

fix(workbench): preserve saved results with non-UTF-8 artifact names - #1289

Merged
mldangelo-oai merged 3 commits into
mainfrom
mdangelo/codex/inventory-selection
Oct 5, 2026
Merged

mldangelo-oai merged 3 commits into
mainfrom
mdangelo/codex/inventory-selection

Conversation

@mldangelo-oai

Copy link
Copy Markdown
Collaborator

Summary

Keep saved scan views readable when a supplemental artifact has a filename that cannot be encoded as UTF-8.

Changes

  • Handle filename encoding failure within the existing safe-path decision, retaining valid findings and artifact links.
  • Extend the existing saved-finding regression with a non-UTF-8 supplemental filename.

Testing

  • The new artifact case failed on the original implementation; the existing artifact control passed.
  • Workbench database suite: 128 passed before the test-only macOS fixture skip. Both affected cases passed again on the final content; pytest emitted two unrelated temporary-directory cleanup warnings.
  • All portable plugin checks passed on the final content: Ruff check/format, SDK build:ci, source compatibility, and all nine compatibility tests.
  • git diff --check passed. Three fresh independent native reviews and verification passed.

Risk and rollout

One production condition moves inside the existing error handler, which also catches filename encoding errors. Valid artifact paths retain their behavior; unencodable supplemental filenames are omitted from the optional artifact list. Existing containment, symlink, and portable-path checks remain in place. The arbitrary-byte filename case skips Windows and macOS; the normal artifact case remains enabled on both. No public CLI or configuration changes.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-05T14:00:32.976404Z f664714 PR opened
🔒 Security Review ✅ Completed 2026-10-05T14:00:10.638109Z f664714 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added the bug Something isn't working label Oct 5, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Unknown error
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@alandelong-oai alandelong-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the full contribution at f66471491ecb65fba567a3c7b5eef9987a1db35e with selected base e4eff6521926241c1ad1df1bb6395b71135e56d3, including changed tests and touched context, using three independent reviews followed by root synthesis.

No supported introduced finding.

Static source review; tests were inspected but not executed. CI, mergeability and integration are separate.

@mldangelo-oai
mldangelo-oai merged commit 73a6974 into main Oct 5, 2026
61 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/inventory-selection branch October 5, 2026 17:38
@github-actions github-actions Bot mentioned this pull request Oct 5, 2026
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants