Skip to content

fix(ci): pin Codex Security smoke test API endpoint - #1293

Merged
mldangelo-oai merged 6 commits into
mainfrom
mdangelo/codex/invoice-desk-inference-endpoint
Oct 5, 2026
Merged

mldangelo-oai merged 6 commits into
mainfrom
mdangelo/codex/invoice-desk-inference-endpoint

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Use the dedicated Codex Security smoke-test environment and the fixed US OpenAI API endpoint through Codex's existing configuration setting. Integrate current main while retaining unattended sample scans.

Changes

  • Preserve the fixed https://us.api.openai.com/v1 endpoint and inherited-variable regression test from the newer PR update.
  • Use the protected codex-security-smoke-test environment and keep the setup guides consistent with unattended scanning.
  • Merge main at d3271641, preserving the newer PR commit.

Testing

  • Workflow shell tests: 9 passed, including the spawned CLI endpoint regression.
  • Source extraction and PR target selection tests: 18 passed.
  • SDK type checks, full package formatting, and CI compilation passed with fresh frozen-lockfile dependencies.
  • actionlint 1.7.12 with ShellCheck 0.11.0 and zizmor 1.30.1 passed.
  • Portable plugin Ruff and source compatibility checks passed.
  • git diff --check passed.
  • Full fixed-seed and random-order SDK runs passed on the unchanged frozen commit in an isolated checkout: 3,616 tests passed, 53 platform/integration skips and zero failures in each run (seeds 12345 and 789142774). The superseded managed-checkout run recorded three fixture-context failures and is not counted as passing.

Risk and rollout

Provision an OPENAI_API_KEY environment secret for a service-account project that supports the US endpoint in codex-security-smoke-test. Keep deployment restricted to protected main, without required reviewers or a wait timer. Endpoint changes require a workflow change. No public CLI options or defaults change. A live inference run still requires credential provisioning.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the bug Something isn't working label Oct 5, 2026
@mldangelo-oai mldangelo-oai changed the title fix(ci): configure Invoice Desk inference endpoint fix(ci): configure the Codex Security smoke test API endpoint Oct 5, 2026
@mldangelo-oai
mldangelo-oai marked this pull request as ready for review October 5, 2026 17:01
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-05T23:09:00.695254Z cb4b94c New commits
🔒 Security Review ✅ Completed 2026-10-05T23:09:26.258494Z cb4b94c New commits

Security findings

Blocking findings (1)

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛡️ Codex Security Review · Automatically triggered

Here are some automated security review suggestions for this pull request.

Reviewed commit: 47fa9a03fa

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Comment thread .github/workflows/invoice-desk-scan.yml Outdated

@alandelong-oai alandelong-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the complete actual PR contribution and changed tests with three independent passes, followed by targeted synthesis. Static review only; product tests were not executed.

[P1] Keep the credential destination inside the protected configuration — .github/workflows/invoice-desk-scan.yml:164

When the protected environment has no OPENAI_BASE_URL variable (the documented default configuration), this vars lookup can resolve a repository variable. A collaborator with repository write access can create that variable without environment-admin access, making the existing protected API key accompany requests to a destination outside the protected setup after a scan is approved. Require an explicitly protected endpoint or keep a fixed endpoint when the protected configuration is absent. This is a conditional source-level issue; I did not inspect the live environment or attempt credential access. I am not claiming a repository variable overrides a configured environment variable.

GitHub documents the repository/environment variable access distinction and vars context: https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/use-variables

These are source findings at the reviewed commit; CI, mergeability and integration remain separate.

@mldangelo-oai mldangelo-oai changed the title fix(ci): configure the Codex Security smoke test API endpoint fix(ci): pin Codex Security smoke test API endpoint Oct 5, 2026

@alandelong-oai alandelong-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the complete contribution and changed tests with three independent review passes plus root synthesis. No supported introduced finding remains at this head. This is a static source review; tests were not executed, and CI and integration remain separate.

@mldangelo-oai
mldangelo-oai merged commit f230f76 into main Oct 5, 2026
64 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/invoice-desk-inference-endpoint branch October 5, 2026 23:50
@github-actions github-actions Bot mentioned this pull request Oct 6, 2026
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants