Repository navigation
fix(ci): pin Codex Security smoke test API endpoint - #1293
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
Security findingsBlocking findings (1)
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🛡️ Codex Security Review · Automatically triggered
Here are some automated security review suggestions for this pull request.
Reviewed commit: 47fa9a03fa
ℹ️ About Codex security reviews in GitHub
This is an experimental Codex feature. Security reviews are triggered when:
- You comment "@codex security review"
- A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review
Once complete, Codex will leave suggestions, or a comment if no findings are found.
alandelong-oai
left a comment
There was a problem hiding this comment.
Reviewed the complete actual PR contribution and changed tests with three independent passes, followed by targeted synthesis. Static review only; product tests were not executed.
[P1] Keep the credential destination inside the protected configuration — .github/workflows/invoice-desk-scan.yml:164
When the protected environment has no OPENAI_BASE_URL variable (the documented default configuration), this vars lookup can resolve a repository variable. A collaborator with repository write access can create that variable without environment-admin access, making the existing protected API key accompany requests to a destination outside the protected setup after a scan is approved. Require an explicitly protected endpoint or keep a fixed endpoint when the protected configuration is absent. This is a conditional source-level issue; I did not inspect the live environment or attempt credential access. I am not claiming a repository variable overrides a configured environment variable.
GitHub documents the repository/environment variable access distinction and vars context: https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/use-variables
These are source findings at the reviewed commit; CI, mergeability and integration remain separate.
alandelong-oai
left a comment
There was a problem hiding this comment.
Reviewed the complete contribution and changed tests with three independent review passes plus root synthesis. No supported introduced finding remains at this head. This is a static source review; tests were not executed, and CI and integration remain separate.
Summary
Use the dedicated Codex Security smoke-test environment and the fixed US OpenAI API endpoint through Codex's existing configuration setting. Integrate current
mainwhile retaining unattended sample scans.Changes
https://us.api.openai.com/v1endpoint and inherited-variable regression test from the newer PR update.codex-security-smoke-testenvironment and keep the setup guides consistent with unattended scanning.mainatd3271641, preserving the newer PR commit.Testing
git diff --checkpassed.Risk and rollout
Provision an
OPENAI_API_KEYenvironment secret for a service-account project that supports the US endpoint incodex-security-smoke-test. Keep deployment restricted to protectedmain, without required reviewers or a wait timer. Endpoint changes require a workflow change. No public CLI options or defaults change. A live inference run still requires credential provisioning.Public disclosure review