Repository navigation
fix: stop Deep Scan from starting extra reviews during result checks - #1630
Merged
Merged
Conversation
ianw-oai
marked this pull request as ready for review
October 14, 2026 05:15
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kmbroai
approved these changes
Oct 14, 2026
Merged
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deep Scan kept starting new reviews while it was still checking whether earlier reviews found anything new. When that check was slow, more reviews could run before Deep Scan knew it should stop.
Changes
Wait for the result check to finish before starting more reviews. Reviews already running can finish, and completed results are still combined into the report.
Add a regression test that holds the result check open and verifies that no more reviews start. Keep coverage for canceling unfinished reviews once the scan decides to stop.
Testing
Passed the required portable checks, TypeScript types and formatting, 14 focused MCP cases and 6 Python cases. The regression fails without the fix and passes with it.
Live CLI runs on a disposable fixture verified normal completion, the discovery deadline and the cost limit.
Broader suites are not fully green. A macOS raw-byte path test fails, and the SDK executor test exceeds its 110-second timeout. The executor tests pass when run directly. Other failures passed after correcting the regression test's timing assumption or rerunning with system Git or without the outer sandbox.
Risk and rollout
Discovery capacity can sit idle while earlier results are checked. Existing options, defaults and saved-scan formats are unchanged.
Public disclosure review