Repository navigation
fix(chat): prevent bubble text truncation - #1400
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f00eb87d-ce22-474b-93e8-f1328eb30afb
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: blocked before merge. Reviewed September 11, 2026, 12:29 PM ET / 16:29 UTC. ClawSweeper reviewWhat this changesUpdates both Reactor UI packages to preview.15 so native chat bubbles use the corrected Markdown list wrapping. Merge readiness⛔ Blocked before merge - 2 items remain Keep open: this remains a useful integration of the upstream fix, and current main still uses the affected dependency version. No introduced correctness defect was found. Priority: P2 Review scores
Verification
How this fits togetherCompanion sends assistant message text through Reactor’s Markdown renderer into native Windows chat bubbles. The dependency controls how list text is measured and wrapped within the bubble. flowchart LR
A[Assistant message] --> B[Chat timeline]
B --> C[Sanitize Markdown]
C --> D[Reactor list layout]
E[Available bubble width] --> D
D --> F[Wrapped native chat text]
Before merge
Agent review detailsSecurityNone. Review metricsNone. Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Keep the shared upstream renderer repair and confirm complete list text remains visible within Companion’s constrained and resized chat bubbles. Do we have a high-confidence way to reproduce the issue? Yes: long plain or bold Markdown list items at constrained width exercise the affected renderer, supported by the reporter’s account and upstream native reproduction. This review did not execute current main. Is this the best way to solve the issue? Yes: adopting the released upstream measurement fix is narrower and more maintainable than introducing a parallel application renderer; the application does not use the affected concrete-type callback. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against c71121cdcdc9. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|

Closes #1362
What Problem This Solves
Fixes an issue where users reading chat bubbles could see text lines cut off mid-display.
Why This Change Was Made
Updates both
Microsoft.UI.ReactorandMicrosoft.UI.Reactor.Advancedfrom0.1.0-preview.14to0.1.0-preview.15. This Reactor release contains Barbara's upstream fix for the chat bubble text truncation reported in #1362.User Impact
Chat bubble text can use the corrected Reactor text layout behavior instead of truncating lines during display.
Evidence
dotnet list .\src\OpenClaw.Tray.WinUI\OpenClaw.Tray.WinUI.csproj package --include-transitiveresolves both Reactor packages to0.1.0-preview.15. The full WinUI build and required shared and tray test suites pass on the current commit.Change Type
Scope
winnodeRequired proof pools
windows-winui-interactive: confirm the upstream Reactor layout fix against the original chat bubble truncation reproduction.Validation
./build.ps1: passed, all 5 projects built successfully forwin-arm64.dotnet test ./tests/OpenClaw.Shared.Tests/OpenClaw.Shared.Tests.csproj --no-restore: passed, 3,989 passed, 34 skipped, 0 failed.dotnet test ./tests/OpenClaw.Tray.Tests/OpenClaw.Tray.Tests.csproj --no-restore: passed, 2,898 passed, 0 skipped, 0 failed.dotnet test ./tests/OpenClaw.Shared.Tests/OpenClaw.Shared.Tests.csproj --no-restore --filter "FullyQualifiedName=OpenClaw.Shared.Tests.McpHttpServerTests.Dispose_DuringInFlightHandler_DoesNotSurfaceObjectDisposedException": passed, 1 passed, 0 failed after a transient failure in an earlier full-suite run.Real Behavior Proof
c43c1dbd.dotnet list ... package --include-transitive, then ran the required build and test suite.Microsoft.UI.ReactorandMicrosoft.UI.Reactor.Advancedboth resolve to0.1.0-preview.15; the WinUI project builds successfully.Yes/No/N/A): N/A.windows-winui-interactive.Security Impact
Yes/No): NoYes/No): NoYes/No): NoYes/No): NoYes/No): NoYes, explain the risk and mitigation: N/ACompatibility and Migration
Yes/No): YesYes/No): NoYes/No): NoReview Conversations