Repository navigation
fix(setup): install a Node runtime supported by the Gateway - #1824
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review endedClawSweeper stopped reviewing this revision because the pull request closed. |
5 of 16 tasks
RomneyDa
marked this pull request as ready for review
October 22, 2026 06:27
8 of 16 tasks
This was referenced Oct 22, 2026
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(setup): install a Node runtime supported by the Gateway This is item 1/1 in the current shard. Shard 0/1. This temporary status tracks the active review worker. The completed review will appear in the durable ClawSweeper review comment. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This was referenced Oct 22, 2026
This was referenced Oct 30, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Fixes: WSL Gateway setup fails before installing the CLI because Companion requests Node 24.19.0, which the official installer no longer accepts.
User Impact
New managed WSL Gateway installations request Node 24.22.1, the current upstream installer minimum. Custom installers and existing Gateway release selection remain unchanged. This is a separate prerequisite for #1474 (feat(release): automate Microsoft Store submission), not part of the Store automation diff.
Why This Change Was Made
Update the existing GatewayInstallPolicy runtime pin. Keep exact post-install runtime verification, HTTPS download-before-execution, cleanup, and custom-installer behavior intact. Two existing command-contract assertions now independently require the supported version. The policy document records the current pin without losing its historical value.
Evidence
Reproduced in all three WSL lanes on unchanged main and Store PR CI:
Node 24.19.0 is unsupported; use Node 24.22.1+ or Node 26.12.1+. Verified the official installer default/minimum and published Node 24.22.1 Linux x64/ARM64 checksums. Current head:38355291f2f915ac0db270881b9b61b4d1538bb6. Independent Codex rubber-duck review of the supplied exact diff found no actionable issue; its filesystem tools were unavailable, so it did not independently execute tests.Change Type
Scope
winnodeRequired proof pools
windows-wsl-gateway-e2e: fresh managed Gateway installation and pairing must complete with the new runtime.windows-wsl-mxc: strict repository setup/connect validation; no skip is counted as proof.Validation
InstallCli,GatewayInstallPolicyTests,SetupReviewSummaryTests): 64 passed, 1 failed in the Windows candidate-copy cancellation fixture. The candidate-copy case passes in the native Windows run; macOS paths are rejected by the Windows-drive validation before the fake copy is reached.Native Windows 11 ARM64 isolated closeout, current source:
./build.ps1dotnet test tests/OpenClaw.Shared.Tests/OpenClaw.Shared.Tests.csproj --no-restoredotnet test tests/OpenClaw.Tray.Tests/OpenClaw.Tray.Tests.csproj --no-restoredotnet test tests/OpenClaw.SetupEngine.Tests/OpenClaw.SetupEngine.Tests.csproj --no-restorescripts/validate-docs.ps1scripts/validate-mxc-e2e.ps1 -NoBuild -RuntimeIdentifier win-arm64Fresh test projects were explicitly built before
--no-restore. Shared/Tray failures are the previously observed VM symlink privilege, ARM64 prerequisite/native DLL, and redirected-known-folder cases. All five SetupEngine failures reproduced on untouched maine4d79798in the same VM (10-case filtered control: 5 passed, 5 failed): four restart-classification message assertions and one native VC-runtime staging check. These are recorded as failures, not waived. Both revised installer contract cases and the macOS-blocked candidate-copy case passed on Windows. No assertion, timeout, or skip policy was weakened.git diff --check: passed.38355291f2f915ac0db270881b9b61b4d1538bb6. 8 successful jobs, 11 classifier/release skips, 0 failed. CI Gate passed.Gateway Node runtime: v24.22.1and complete fresh setup. Hosted MXC exclusions remain exclusions, not strict containment proof.Real Behavior Proof
38355291f2f915ac0db270881b9b61b4d1538bb6(same source as the post-change tests).dotnet test tests/OpenClaw.SetupEngine.Tests/OpenClaw.SetupEngine.Tests.csproj --filter 'FullyQualifiedName~InstallCli_BuildInstallCommand_DefaultsToInstallerLatest|FullyQualifiedName~InstallCli_BuildInstallCommand_DownloadsCompletelyBeforeExecuting'.--node-version '24.22.1'; both assertions pass. Each hosted WSL lane logsGateway Node runtime: v24.22.1, completes fresh setup, and passes its selected recovery/connect tests.Security Impact
Compatibility and Migration
Review Conversations