Skip to content

Update tests for opencloud-eu/reva#655 - #2889

Merged
rhafer merged 2 commits into
opencloud-eu:mainfrom
rhafer:reva-655
Jun 25, 2026
Merged

rhafer merged 2 commits into
opencloud-eu:mainfrom
rhafer:reva-655

Conversation

@rhafer

@rhafer rhafer commented Jun 3, 2026 •

Copy link
Copy Markdown
Member

In order to merge opencloud-eu/reva#655 we need to adjust the acceptance test first and temporary move reva to a fork.

@codacy-production

codacy-production Bot commented Jun 3, 2026 •

Copy link
Copy Markdown

Up to standards βœ…

🟒 Issues 0 issues

Results:
0 new issues

View in Codacy

🟒 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

🟒 Coverage βˆ… diff coverage

Metric Results
Coverage variation Report missing for 716287c1
Diff coverage βœ… βˆ… diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (716287c) Report Missing Report Missing Report Missing
Head commit (a395109) 82282 18943 23.02%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#2889) 0 0 βˆ… (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

1 Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@rhafer

rhafer commented Jun 3, 2026

Copy link
Copy Markdown
Member Author

@michaelstingl I've cherry-picked the test fixes from your fork.

rhafer and others added 2 commits June 25, 2026 16:11
opencloud-eu/reva#655 changes the TUS create response for an invalid name
from 412 to 400. Update the invalid-name scenario to match.

Each example now carries its own expected status in an <http-status-code>
column. Names that fail ValidateName expect 400. The three folder/file rows
stay 412: filename() applies path.Base first, so "folder/file" becomes the
valid leaf "file" and never reaches the changed branch.

lowLevelCreationExtension.feature is unchanged; its missing-Upload-Length
case still returns 412.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@rhafer rhafer changed the title bump reva to fork for adjusting tests Update tests for opencloud-eu/reva#655 Jun 25, 2026
@rhafer
rhafer requested review from aduffeck and v-scharf and removed request for aduffeck June 25, 2026 14:15
@rhafer
rhafer marked this pull request as ready for review June 25, 2026 14:16
@rhafer
rhafer merged commit ca37571 into opencloud-eu:main Jun 25, 2026
63 of 64 checks passed
@openclouders openclouders mentioned this pull request Jun 25, 2026
1 task
sdwilsh pushed a commit to sdwilsh/ansible-playbooks that referenced this pull request Jul 15, 2026
##### [\`7.3.0\`](https://github.com/opencloud-eu/opencloud/blob/HEAD/CHANGELOG.md#730---2026-07-14)

##### πŸ› Bug Fixes

- fix(proxy): honor access token cache ttl \[[#3056](opencloud-eu/opencloud#3056)]
- chore(idp): update axios \[[#3094](opencloud-eu/opencloud#3094)]
- fix: make the collaboration service events optional \[[#3001](opencloud-eu/opencloud#3001)]
- Revert "fix: disallow thumbnails for tiff and jpeg2000 images" \[[#2973](opencloud-eu/opencloud#2973)]
- bump reva \[[#2950](opencloud-eu/opencloud#2950)]
- change error level for trashing items interaction with search \[[#2951](opencloud-eu/opencloud#2951)]
- fix: Send SSE events for SpaceEnabled/Disabled to affected users \[[#2871](opencloud-eu/opencloud#2871)]

##### πŸ“š Documentation

- update collaboration readme \[[#3076](opencloud-eu/opencloud#3076)]
- fix: fix typo in proxy service documentation \[[#3089](opencloud-eu/opencloud#3089)]
- roling release template \[[#2972](opencloud-eu/opencloud#2972)]
- enhance: fix typos in webfinger service description \[[#2958](opencloud-eu/opencloud#2958)]

##### βœ… Tests

- \[full-ci] gherkin steps refactoring. cleaning code \[[#3100](opencloud-eu/opencloud#3100)]
- \[decomposed] more cli command tests \[[#3087](opencloud-eu/opencloud#3087)]
- test(apiSpaces): a space admin can delete a space with no manager \[[#3040](opencloud-eu/opencloud#3040)]
- Update tests for [opencloud-eu/reva#655](opencloud-eu/reva#655) \[[#2889](opencloud-eu/opencloud#2889)]
- api-test: deleting space \[[#2970](opencloud-eu/opencloud#2970)]

##### πŸ“ˆ Enhancement

- feat: add disableSponsorLink web config option \[[#3093](opencloud-eu/opencloud#3093)]
- feat(graph): add MS Graph colon-syntax path lookup middleware \[[#2688](opencloud-eu/opencloud#2688)]
- feat: adjust theme chrome colors and logos \[[#2599](opencloud-eu/opencloud#2599)]
- add tls support for all nats connections \[[#2063](opencloud-eu/opencloud#2063)]
- feat: add more roles \[[#2928](opencloud-eu/opencloud#2928)]
- next to main \[[#2924](opencloud-eu/opencloud#2924)]
- feat: add core apps env variable to override the default core apps \[[#2930](opencloud-eu/opencloud#2930)]

##### πŸ“¦οΈ Dependencies

- build(deps): bump golang.org/x/image from 0.43.0 to 0.44.0 \[[#3112](opencloud-eu/opencloud#3112)]
- build(deps): bump golang.org/x/text from 0.39.0 to 0.40.0 \[[#3101](opencloud-eu/opencloud#3101)]
- \[full-ci] chore: bump web to v7.2.0 \[[#3121](opencloud-eu/opencloud#3121)]
- build(deps): bump golang.org/x/term from 0.44.0 to 0.45.0 \[[#3103](opencloud-eu/opencloud#3103)]
- build(deps): bump github.com/coreos/go-oidc/v3 from 3.19.0 to 3.20.0 \[[#3102](opencloud-eu/opencloud#3102)]
- build(deps): bump golang.org/x/text from 0.38.0 to 0.39.0 \[[#3085](opencloud-eu/opencloud#3085)]
- build(deps): bump github.com/go-chi/chi/v5 from 5.3.0 to 5.3.1 \[[#3073](opencloud-eu/opencloud#3073)]
- build(deps): bump github.com/nats-io/nats-server/v2 from 2.14.2 to 2.14.3 \[[#3063](opencloud-eu/opencloud#3063)]
- build(deps): bump github.com/gookit/config/v2 from 2.2.8 to 2.2.9 \[[#3075](opencloud-eu/opencloud#3075)]
- build(deps): bump github.com/open-policy-agent/opa from 1.18.1 to 1.18.2 \[[#3061](opencloud-eu/opencloud#3061)]
- build(deps): bump github.com/kovidgoyal/imaging from 1.8.21 to 1.8.22 \[[#3060](opencloud-eu/opencloud#3060)]
- build(deps): bump github.com/libregraph/lico from 0.66.0 to 0.67.0 \[[#3028](opencloud-eu/opencloud#3028)]
- chore: bump web to v7.2.0-beta.3 \[[#2953](opencloud-eu/opencloud#2953)]
- chore: bump reva to latest main \[[#2943](opencloud-eu/opencloud#2943)]
flash7777 pushed a commit to flash7777/opencloud that referenced this pull request Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants